You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/13 15:53:34 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request #9661: Support object array insertion for PostgreSQL proxy
sandynz opened a new pull request #9661:
URL: https://github.com/apache/shardingsphere/pull/9661
Fixes #9602.
Changes proposed in this pull request:
- Support object array insertion for PostgreSQL proxy
Solution description:
- Only one dimension array is supported
- Null array element is not supported except String type (char, varchar, text), since `BackendConnection` does not support `connection.createArrayOf` and `statement.setArray` for now, `statement.setArray` will be replaced to `statement.setObject`, and `statement.setObject` just support primitive array (e.g. int[]) and String[]
- Supported PostgreSQL column data types: smallint, integer, bigint, float4(real), float8(double precision), boolean, char, varchar, text. Related Java types: Short[], Inteter[], Long[], Float[], Double[], Boolean[], String[].
- User end usage example:
```
statement.setArray(index++, connection.createArrayOf("integer", new Integer[] {11, 12}));
statement.setArray(index++, connection.createArrayOf("float4", new Float[] {11.1F, 12.1F}));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #9661: Support object array insertion for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9661:
URL: https://github.com/apache/shardingsphere/pull/9661#issuecomment-798593363
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/shardingsphere/pull/9661?src=pr&el=desc) (04af5fa) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7b776770b8ea93853d274fd931d08251e3b32e7f?el=desc) (7b77677) will **decrease** coverage by `0.03%`.
> The diff coverage is `83.95%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
============================================
- Coverage 67.24% 67.20% -0.04%
- Complexity 673 681 +8
============================================
Files 1654 1667 +13
Lines 27616 27801 +185
Branches 4909 4938 +29
============================================
+ Hits 18570 18684 +114
- Misses 7688 7743 +55
- Partials 1358 1374 +16
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9661?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bind/protocol/PostgreSQLArrayParameterDecoder.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMQXJyYXlQYXJhbWV0ZXJEZWNvZGVyLmphdmE=) | `77.10% <77.10%> (ø)` | `1.00 <1.00> (?)` | |
| [...otocol/PostgreSQLBoolArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMQm9vbEFycmF5QmluYXJ5UHJvdG9jb2xWYWx1ZS5qYXZh) | `87.50% <87.50%> (ø)` | `1.00 <1.00> (?)` | |
| [...ocol/PostgreSQLFloat4ArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMRmxvYXQ0QXJyYXlCaW5hcnlQcm90b2NvbFZhbHVlLmphdmE=) | `87.50% <87.50%> (ø)` | `1.00 <1.00> (?)` | |
| [...ocol/PostgreSQLFloat8ArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMRmxvYXQ4QXJyYXlCaW5hcnlQcm90b2NvbFZhbHVlLmphdmE=) | `87.50% <87.50%> (ø)` | `1.00 <1.00> (?)` | |
| [...otocol/PostgreSQLInt2ArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMSW50MkFycmF5QmluYXJ5UHJvdG9jb2xWYWx1ZS5qYXZh) | `87.50% <87.50%> (ø)` | `1.00 <1.00> (?)` | |
| [...otocol/PostgreSQLInt4ArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMSW50NEFycmF5QmluYXJ5UHJvdG9jb2xWYWx1ZS5qYXZh) | `87.50% <87.50%> (ø)` | `1.00 <1.00> (?)` | |
| [...otocol/PostgreSQLInt8ArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMSW50OEFycmF5QmluYXJ5UHJvdG9jb2xWYWx1ZS5qYXZh) | `87.50% <87.50%> (ø)` | `1.00 <1.00> (?)` | |
| [...ocol/PostgreSQLStringArrayBinaryProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMU3RyaW5nQXJyYXlCaW5hcnlQcm90b2NvbFZhbHVlLmphdmE=) | `87.50% <87.50%> (ø)` | `1.00 <1.00> (?)` | |
| [...protocol/PostgreSQLBinaryProtocolValueFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9iaW5hcnkvYmluZC9wcm90b2NvbC9Qb3N0Z3JlU1FMQmluYXJ5UHJvdG9jb2xWYWx1ZUZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `22.22% <0.00%> (-29.63%)` | `0.00% <0.00%> (ø%)` | |
| ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9661?src=pr&el=footer). Last update [7b77677...04af5fa](https://codecov.io/gh/apache/shardingsphere/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 merged pull request #9661: Support object array insertion for PostgreSQL proxy
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #9661:
URL: https://github.com/apache/shardingsphere/pull/9661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org