You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Josh Elser <jo...@gmail.com> on 2012/08/01 23:55:03 UTC
Re: Review Request: Add import/export table
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/#review9723
-----------------------------------------------------------
/trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java
<https://reviews.apache.org/r/6138/#comment20703>
Swap "<import dir>" for "<export dir>"
- Josh Elser
On July 31, 2012, 9:51 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:51 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch to add import and export table to Accumulo
>
>
> This addresses bug ACCUMULO-456.
> https://issues.apache.org/jira/browse/ACCUMULO-456
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
> /trunk/core/src/main/thrift/client.thrift 1366092
> /trunk/core/src/main/thrift/master.thrift 1366092
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1366092
> /trunk/docs/examples/README.export PRE-CREATION
> /trunk/docs/src/user_manual/chapters/table_configuration.tex 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java PRE-CREATION
> /trunk/test/system/randomwalk/conf/modules/Shard.xml 1366092
>
> Diff: https://reviews.apache.org/r/6138/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kturner
>
>
Re: Review Request: Add import/export table
Posted by Josh Elser <jo...@gmail.com>.
> On Aug. 1, 2012, 9:55 p.m., Josh Elser wrote:
> > /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java, line 39
> > <https://reviews.apache.org/r/6138/diff/2/?file=131581#file131581line39>
> >
> > Swap "<import dir>" for "<export dir>"
Ignoring my reversal there, I see how you might have intended that. Perhaps "<exported table dir>" or "<dir to import>" would be more clear?
- Josh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/#review9723
-----------------------------------------------------------
On July 31, 2012, 9:51 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:51 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch to add import and export table to Accumulo
>
>
> This addresses bug ACCUMULO-456.
> https://issues.apache.org/jira/browse/ACCUMULO-456
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
> /trunk/core/src/main/thrift/client.thrift 1366092
> /trunk/core/src/main/thrift/master.thrift 1366092
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1366092
> /trunk/docs/examples/README.export PRE-CREATION
> /trunk/docs/src/user_manual/chapters/table_configuration.tex 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java PRE-CREATION
> /trunk/test/system/randomwalk/conf/modules/Shard.xml 1366092
>
> Diff: https://reviews.apache.org/r/6138/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kturner
>
>