[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5073: [Relay][Frontend][ONNX] operator support NonZero

[GitBox <gi...@apache.org>]

jwfromm commented on a change in pull request #5073: [Relay][Frontend][ONNX] operator support NonZero
URL: https://github.com/apache/incubator-tvm/pull/5073#discussion_r393310531
 
 

 ##########
 File path: tests/python/frontend/onnx/test_forward.py
 ##########
 @@ -30,7 +30,8 @@
 import scipy
 
 
-def get_tvm_output(graph_def, input_data, target, ctx, output_shape=None, output_dtype='float32', opset=None):
+def get_tvm_output(graph_def, input_data, target, ctx, output_shape=None, output_dtype='float32',
+                   opset=None, mode=None):
 
 Review comment:
   Just curious, why does `mode` need to be added? Does `NonZero` only work in the VM executor? If so, maybe we can just exclusively use the VM for testing, I'm not sure there's a need to support both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services