You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/02/16 16:12:39 UTC
[GitHub] [netbeans] sjaenick opened a new pull request #3618: Update Apache Felix to 7.0.3 release
sjaenick opened a new pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618
Minor change: Update Apache Felix from 7.0.0 to 7.0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1046145344
Change look sane to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1045971859
changelog: https://github.com/apache/felix-dev/blob/master/framework/doc/changelog.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1046561749
How does it all connect?
* first of all there was [Netigso](http://wiki.apidesign.org/wiki/Netigso)
* then we realized we need [Netbinox](http://wiki.apidesign.org/wiki/Netbinox) to
* be able to run [Mylyn](http://wiki.apidesign.org/wiki/Mylyn)
NetBeans usually prefer so called [modular libraries](http://wiki.apidesign.org/wiki/Modular_library) - as such NetBeans rather include direct OSGi JARs than using their copy included in Felix or Equinox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1046594979
@JaroslavTulach I remember reading your wiki back when i tried to get things to work on JDK 17. How did it evolve from there? Is netigso running all nb modules? Or did it stay a optional bridge for client apps to load their osgi libs with. I don't think mylyn is used anywhere in the IDE or is it? Maybe we are updating here something which isn't even used anywhere :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1047182999
Thank you for the update. I looked into the code base and core.kit, core.osgi, autoupdate.services and core.netigso have direct dependencies on felix, at least for tests. So we have at least partitial coverage. I restartet the failing tests and if noone objects, I would be willing to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1046510771
i ran a fulltext search to find out the modules with direct dependencies to this osgi wrapper module and quite a few do.
```
org.netbeans.modules.bugzilla
org.netbeans.modules.java.mx.project
org.netbeans.modules.maven.osgi
org.netbeans.core.netigso
org.netbeans.modules.netbinox
```
I don't really know how this all connects since netbinox itself wraps a very old version of osgi (3.9). I just know that the last time i tried to run tests on JDK 17, that version got in the way. So I assume that 3.9 isn't actually used at runtime (otherwise it would fail there too?). Maybe @JaroslavTulach can help out here, I am curious how this works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1046323397
> Where's the upstream notice file coming from? Wasn't able to find it.
For Apache Projects I would always look first in the JAR itself. You can't be required to include a NOTICE you don't have. There are two main places to look:
- the root of the JAR
- the META-INF folder
If that fails, I would look into the repository of the project (but if a project does not follow its own rules, this might already be to much).
> Also, untested, since this is only a minor bugfix update.
I changes behavior in classloaders and using Unsafe. Two notoriously incompatible places. Changes without checks are bad. Always. At least a manual check has to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1046603977
Both Felix and Netbinox (enhanced Equinox) are included in the platform cluster. Many applications built on the NetBeans Platform (including for example VSCode, right @sdedic?) are fine with Felix. However NetBeans IDE needs Netbinox because Eclipse originated OSGi bundles like https://github.com/apache/netbeans/tree/master/ide/o.eclipse.mylyn.commons.core & co. use `Require-Bundle` directive in manifest that can only be satisfied by including Equinox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sjaenick commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
sjaenick commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1046210586
Where's the upstream notice file coming from? Wasn't able to find it.
Also, untested, since this is only a minor bugfix update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sjaenick commented on pull request #3618: Update Apache Felix to 7.0.3 release
Posted by GitBox <gi...@apache.org>.
sjaenick commented on pull request #3618:
URL: https://github.com/apache/netbeans/pull/3618#issuecomment-1047082966
> > Where's the upstream notice file coming from? Wasn't able to find it.
>
> For Apache Projects I would always look first in the JAR itself. You can't be required to include a NOTICE you don't have. There are two main places to look:
>
> * the root of the JAR
>
> * the META-INF folder
Thanks for the pointer, indeed it exists within the META-INF folder of the jar; I updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists