[jira] [Commented] (OAK-3942) Convert tests for TreeLocation and ImmutableTree to regular unit tests

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121220#comment-15121220 ] 

Alex Parvulescu commented on OAK-3942:
--------------------------------------

bq. I will therefore move them back to oak-core and refactor to regular unit tests.
If I were to venture a guess, they extend {{OakBaseTest}} because these are generic tests that need to run against _all_ existing NodeStore impls, which is not something possible from within {{oak-core}} due to cyclic dependencies. I would only move them back if it's possible to do so without losing the genericness.

> Convert tests for TreeLocation and ImmutableTree to regular unit tests
> ----------------------------------------------------------------------
>
>                 Key: OAK-3942
>                 URL: https://issues.apache.org/jira/browse/OAK-3942
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, it
>            Reporter: angela
>            Assignee: angela
>
> while moving out all IT test into a separate module, {{ImmutableTreeTest}} and {{TreeLocationTest}} got moved because they extended from {{OakBaseTest}}. IMO however, they are just regular unit tests that don't need to be run against various fixtures... as discussed with [~frm] they most probably became ITs by mistake not because they actually are ITs.
> I will therefore move them back to {{oak-core}} and refactor to regular unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)