You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/05 06:58:18 UTC
[GitHub] [yunikorn-scheduler-interface] steinsgateted opened a new pull request, #70: [YUNIKORN-1270] Removal of unused queue field in Allocation
steinsgateted opened a new pull request, #70:
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/70
### What is this PR for?
remove the queue from the Allocation message
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1270
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-scheduler-interface] wilfred-s commented on a diff in pull request #70: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on code in PR #70:
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/70#discussion_r939745366
##########
scheduler-interface-spec.md:
##########
@@ -505,8 +505,6 @@ message Allocation {
Resource resourcePerAlloc = 5;
// Priority of ask
int32 priority = 6;
- // Queue which the allocation belongs to
- string queueName = 7;
Review Comment:
Can we reserve this ID and name so it cannot be reused?
```
reserved 7;
reserved "queueName"
```
This will prevent re-using the same ID when we update later, which can cause all kinds of issues. The reserved lines can be used to replace the existing lines in the message or at the start/end of the message.
NIT: now that we are making a change here fixing the indentation of the lines 505 to 510 might be nice too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-scheduler-interface] steinsgateted commented on a diff in pull request #70: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on code in PR #70:
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/70#discussion_r939924921
##########
scheduler-interface-spec.md:
##########
@@ -505,8 +505,6 @@ message Allocation {
Resource resourcePerAlloc = 5;
// Priority of ask
int32 priority = 6;
- // Queue which the allocation belongs to
- string queueName = 7;
Review Comment:
Thanks for your review.
Add reserve at the end of the message, then add blank lines from 505 to 510.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-scheduler-interface] steinsgateted commented on a diff in pull request #70: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on code in PR #70:
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/70#discussion_r939924921
##########
scheduler-interface-spec.md:
##########
@@ -505,8 +505,6 @@ message Allocation {
Resource resourcePerAlloc = 5;
// Priority of ask
int32 priority = 6;
- // Queue which the allocation belongs to
- string queueName = 7;
Review Comment:
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-scheduler-interface] wilfred-s closed pull request #70: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #70: [YUNIKORN-1270] Removal of unused queue field in Allocation
URL: https://github.com/apache/yunikorn-scheduler-interface/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org