[GitHub] [hudi] jp0317 commented on a diff in pull request #8898: [HUDI-6333] allow using manifest file directly to create a bigquery external table

["jp0317 (via GitHub)" <gi...@apache.org>]

jp0317 commented on code in PR #8898:
URL: https://github.com/apache/hudi/pull/8898#discussion_r1237202198


##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java:
##########
@@ -82,6 +83,14 @@ public void syncHoodieTable() {
     }
   }
 
+  private boolean tableExists(HoodieBigQuerySyncClient bqSyncClient, String tableName) {
+    if (bqSyncClient.tableExists(tableName)) {
+      LOG.info(tableName + " already exists");

Review Comment:
   not necessary, it's just to avoid the redundant code  logging table already exists. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org