You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Joerg Schad (JIRA)" <ji...@apache.org> on 2015/02/11 18:29:13 UTC
[jira] [Comment Edited] (MESOS-2309) Mesos rejects ExecutorInfo as
incompatible when there is no functional difference
[ https://issues.apache.org/jira/browse/MESOS-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316582#comment-14316582 ]
Joerg Schad edited comment on MESOS-2309 at 2/11/15 5:29 PM:
-------------------------------------------------------------
On the one hand you can argue that functionally both \-the default value and the explicit value\- are equivalent.
On the other hand it is a different ExecutorInfo when I set a value explicitly (which I personally even find intuitive). Imagine for example that you have mixed ExecutorInfos with default and explicit values and now then the default value is changed for some reason.
One other reason for inequality is the added complexity for the comparison which also needs to maintained for future added fields in the protobuf. This in comparison to the expected gain I find quite a high price...
was (Author: js84):
On the one hand you can argue that functionally both -the default value and the explicit value- are equivalent.
On the other hand it is a different ExecutorInfo when I set a value explicitly (which I personally even find intuitive). Imagine for example that you have mixed ExecutorInfos with default and explicit values and now then the default value is changed for some reason.
One other reason for inequality is the added complexity for the comparison which also needs to maintained for future added fields in the protobuf. This in comparison to the expected gain I find quite a high price...
> Mesos rejects ExecutorInfo as incompatible when there is no functional difference
> ---------------------------------------------------------------------------------
>
> Key: MESOS-2309
> URL: https://issues.apache.org/jira/browse/MESOS-2309
> Project: Mesos
> Issue Type: Bug
> Reporter: Zameer Manji
> Assignee: Joerg Schad
> Priority: Minor
>
> In AURORA-1076 it was discovered that if an ExecutorInfo was changed such that a previously unset optional field with a default value was changed to have the field set with the default value, it would be rejected as not compatible.
> For example if we have an ExecutorInfo with a CommandInfo with the {{shell}} attribute unset and then we change the CommandInfo to set the {{shell}} attribute to true Mesos will reject the task with:
> {noformat}
> I0130 21:50:05.373389 50869 master.cpp:3441] Sending status update TASK_LOST (UUID: 82ef615c-0d59-4427-95d5-80cf0e52b3fc) for task system-gc-c89c0c05-200c-462e-958a-ecd7b9a76831 of framework 201103282247-0000000019-0000 'Task has invalid ExecutorInfo (existing ExecutorInfo with same ExecutorID is not compatible).
> {noformat}
> This is not intuitive because the default value of the {{shell}} attribute is true. There should be no difference between not setting an optional field with a default value and setting that field to the default value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)