[GitHub] [incubator-doris] morningman commented on a change in pull request #7067: [Feature] Support config scheduling strategy.

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7067:
URL: https://github.com/apache/incubator-doris/pull/7067#discussion_r747603771



##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -384,6 +386,9 @@
     @VariableMgr.VarAttr(name = ENABLE_LATERAL_VIEW, needForward = true)
     public boolean enableLateralView = false;
 
+    @VariableMgr.VarAttr(name = EXEC_SCHEDULING_STRATEGY)
+    public String execSchedulingStrategy = ExecSchedulingStrategy.EVENLY_BACKEND.name();

Review comment:
       For `String` type session variable, user may set any unexpected values.
   I think you refer `sql_mode` or `runtime_filter_type`.
   And also refer to the `VariableVarConverters.java`

##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
##########
@@ -1456,6 +1463,47 @@ private void computeScanRangeAssignmentByScheduler(
         }
     }
 
+    private void computeScanRangeAssignmentWithMinNodeStrategy(

Review comment:
       Could you please add some comment to explain the logic of this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org