[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6429: Do not run avro sqllogictests tests unless the avro feature is enabled

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #6429:
URL: https://github.com/apache/arrow-datafusion/pull/6429#discussion_r1202104461


##########
datafusion/core/tests/sqllogictests/src/main.rs:
##########
@@ -84,7 +84,10 @@ async fn run_test_file(
     relative_path: PathBuf,
 ) -> Result<(), Box<dyn Error>> {
     info!("Running with DataFusion runner: {}", path.display());
-    let test_ctx = context_for_test_file(&relative_path).await;
+    let Some(test_ctx) = context_for_test_file(&relative_path).await else {
+        info!("Skipping: {}", path.display());

Review Comment:
   I think this will log twice, once in context_for_test_file and once here. I feel at least one of these is redundant...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org