You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by su...@apache.org on 2023/05/18 05:50:37 UTC
[shardingsphere] branch master updated: Fix sonar issue of UnlabelComputeNodeUpdater (#25758)
This is an automated email from the ASF dual-hosted git repository.
sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new f225ab4d643 Fix sonar issue of UnlabelComputeNodeUpdater (#25758)
f225ab4d643 is described below
commit f225ab4d64382b5c7c5c39dc29f0e280602475ff
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Thu May 18 13:50:29 2023 +0800
Fix sonar issue of UnlabelComputeNodeUpdater (#25758)
---
.../handler/distsql/ral/updatable/UnlabelComputeNodeUpdater.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/UnlabelComputeNodeUpdater.java b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/UnlabelComputeNodeUpdater.java
index 1ea08a262ae..e7cf3ffb0f5 100644
--- a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/UnlabelComputeNodeUpdater.java
+++ b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/UnlabelComputeNodeUpdater.java
@@ -42,8 +42,8 @@ public final class UnlabelComputeNodeUpdater implements RALUpdater<UnlabelComput
@Override
public void executeUpdate(final String databaseName, final UnlabelComputeNodeStatement sqlStatement) {
MetaDataBasedPersistService persistService = ProxyContext.getInstance().getContextManager().getMetaDataContexts().getPersistService();
- ShardingSpherePreconditions.checkState(null != persistService.getRepository() && persistService.getRepository() instanceof ClusterPersistRepository,
- () -> new UnsupportedSQLOperationException("Labels can only be removed in cluster mode"));
+ ShardingSpherePreconditions.checkState(persistService.getRepository() instanceof ClusterPersistRepository,
+ () -> new UnsupportedSQLOperationException("Labels can only be removed in cluster mode."));
String instanceId = sqlStatement.getInstanceId();
ContextManager contextManager = ProxyContext.getInstance().getContextManager();
Optional<ComputeNodeInstance> computeNodeInstance = contextManager.getInstanceContext().getComputeNodeInstanceById(instanceId);