You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2021/04/20 17:49:27 UTC

[kudu-CR] [java] Add Kerberos-support to test harness 

Hello Alexey Serbin, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/17327

to review the following change.


Change subject: [java] Add Kerberos-support to test harness
......................................................................

[java] Add Kerberos-support to test harness

MiniCluster supports Kerberos, but there was no simple way to enable
Kerberos through the test harness. This patch adds an @EnableKerberos
annotation that can be used on test methods to enable Kerberos on the
mini-cluster with the option to specify the service principal name.

Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
2 files changed, 31 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/17327/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 Apr 2021 18:08:31 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17327

to look at the new patch set (#2).

Change subject: [java] Add Kerberos-support to test harness
......................................................................

[java] Add Kerberos-support to test harness

MiniCluster supports Kerberos, but there was no simple way to enable
Kerberos through the test harness. This patch adds an @EnableKerberos
annotation that can be used on test methods to enable Kerberos on the
mini-cluster with the option to specify the service principal name.

Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
2 files changed, 32 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/17327/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 Apr 2021 16:48:51 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17327

to look at the new patch set (#4).

Change subject: [java] Add Kerberos-support to test harness
......................................................................

[java] Add Kerberos-support to test harness

MiniCluster supports Kerberos, but there was no simple way to enable
Kerberos through the test harness. This patch adds an @EnableKerberos
annotation that can be used on test methods to enable Kerberos on the
mini-cluster with the option to specify the service principal name.

Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
3 files changed, 41 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/17327/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 Apr 2021 19:53:13 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 Apr 2021 19:53:27 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................

[java] Add Kerberos-support to test harness

MiniCluster supports Kerberos, but there was no simple way to enable
Kerberos through the test harness. This patch adds an @EnableKerberos
annotation that can be used on test methods to enable Kerberos on the
mini-cluster with the option to specify the service principal name.

Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Reviewed-on: http://gerrit.cloudera.org:8080/17327
Tested-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
3 files changed, 41 insertions(+), 3 deletions(-)

Approvals:
  Attila Bukor: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Patch Set 2:

Can you add or modify a test to use this?


-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 Apr 2021 16:56:13 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Apr 2021 01:01:26 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 Apr 2021 16:54:12 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17327

to look at the new patch set (#3).

Change subject: [java] Add Kerberos-support to test harness
......................................................................

[java] Add Kerberos-support to test harness

MiniCluster supports Kerberos, but there was no simple way to enable
Kerberos through the test harness. This patch adds an @EnableKerberos
annotation that can be used on test methods to enable Kerberos on the
mini-cluster with the option to specify the service principal name.

Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
3 files changed, 41 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/17327/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Add Kerberos-support to test harness

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17327 )

Change subject: [java] Add Kerberos-support to test harness
......................................................................


Patch Set 3:

> Patch Set 2:
> 
> Can you add or modify a test to use this?

Sure, changed one.


-- 
To view, visit http://gerrit.cloudera.org:8080/17327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f46c0b88594d978f87c344f53dffd06aad5b6e1
Gerrit-Change-Number: 17327
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 Apr 2021 17:43:47 +0000
Gerrit-HasComments: No