You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "M. Manna" <ma...@gmail.com> on 2018/10/03 12:58:03 UTC

Re: [VOTE] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

Since this has been open for a while, I am assuming that it's good to go?

if so, I will update the KIP page - and start coding this. I would prefer
re-using existing tests written for DefaultPartitioner, so that we don't
need to write new tests.

Regards,

On Sun, 30 Sep 2018 at 19:34, Matthias J. Sax <ma...@confluent.io> wrote:

> +1 (binding)
>
> @Abhimanyu: can you please update the table in
>
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
> and add a link to the KIP. Thanks.
>
> -Matthias
>
> On 9/4/18 9:56 PM, Abhimanyu Nagrath wrote:
> > +1
> >
> > On Wed, Sep 5, 2018 at 2:39 AM Magesh Nandakumar <ma...@confluent.io>
> > wrote:
> >
> >> +1 ( non-binding)
> >>
> >> On Tue, Sep 4, 2018 at 3:39 AM M. Manna <ma...@gmail.com> wrote:
> >>
> >>> Hello,
> >>>
> >>> I have made necessary changes as per the original discussion thread,
> and
> >>> would like to put it for votes.
> >>>
> >>> Thank you very much for your suggestion and guidance so far.
> >>>
> >>> Regards,
> >>>
> >>
> >
>
>

Re: [VOTE] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

Posted by ha...@fastmail.fm.
Having Round-robin partitioner as default makes sense.
+1 (binding).

Thanks,
Harsha
On Oct 19, 2018, 9:54 AM -0700, Matthias J. Sax <ma...@confluent.io>, wrote:
> People a currently quite busy with 2.1.0 and 2.0.1 releases. That's why
> the vote might go slow.
>
> Just keep bumping the vote thread on a weekly bases... Thanks for your
> patients.
>
>
> -Matthias
>
> On 10/19/18 1:08 AM, M. Manna wrote:
> > Since this has gone quiet, could I prequest 1 more vote here - if anyone
> > thinks it's worth doing?
> >
> > Thanks,
> >
> >
> >
> > On Wed, 3 Oct 2018 at 16:14, M. Manna <ma...@gmail.com> wrote:
> >
> > > Thanks for reminding me about the "Binding" vote Bill. I remember some
> > > people with non-binding vote, so jumped the gun a bit too early.
> > > We will wait for 2 more as you stated.
> > >
> > > Regards,
> > >
> > > On Wed, 3 Oct 2018 at 16:07, Bill Bejeck <bb...@gmail.com> wrote:
> > >
> > > > +1 from me.
> > > >
> > > > As for closing the vote, it needs to be open for a minimum of 72 and
> > > > requires three binding +1 votes. Additionally, there needs more +1
> > > > binding
> > > > votes than -1 votes. The description for the lazy majority vote process
> > > > is
> > > > described here
> > > > https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals
> > > > .
> > > >
> > > > I haven't been tracking the vote results, but from what I can see in the
> > > > voting thread, this KIP still requires two more +1 binding votes.
> > > >
> > > > HTH,
> > > > BIll
> > > >
> > > > On Wed, Oct 3, 2018 at 8:58 AM M. Manna <ma...@gmail.com> wrote:
> > > >
> > > > > Since this has been open for a while, I am assuming that it's good to
> > > > go?
> > > > >
> > > > > if so, I will update the KIP page - and start coding this. I would
> > > > prefer
> > > > > re-using existing tests written for DefaultPartitioner, so that we don't
> > > > > need to write new tests.
> > > > >
> > > > > Regards,
> > > > >
> > > > > On Sun, 30 Sep 2018 at 19:34, Matthias J. Sax <ma...@confluent.io>
> > > > > wrote:
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > > @Abhimanyu: can you please update the table in
> > > > > >
> > > > > >
> > > > >
> > > > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
> > > > > > and add a link to the KIP. Thanks.
> > > > > >
> > > > > > -Matthias
> > > > > >
> > > > > > On 9/4/18 9:56 PM, Abhimanyu Nagrath wrote:
> > > > > > > +1
> > > > > > >
> > > > > > > On Wed, Sep 5, 2018 at 2:39 AM Magesh Nandakumar <
> > > > mageshn@confluent.io
> > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > +1 ( non-binding)
> > > > > > > >
> > > > > > > > On Tue, Sep 4, 2018 at 3:39 AM M. Manna <ma...@gmail.com>
> > > > wrote:
> > > > > > > >
> > > > > > > > > Hello,
> > > > > > > > >
> > > > > > > > > I have made necessary changes as per the original discussion
> > > > thread,
> > > > > > and
> > > > > > > > > would like to put it for votes.
> > > > > > > > >
> > > > > > > > > Thank you very much for your suggestion and guidance so far.
> > > > > > > > >
> > > > > > > > > Regards,
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

Posted by "Matthias J. Sax" <ma...@confluent.io>.
People a currently quite busy with 2.1.0 and 2.0.1 releases. That's why
the vote might go slow.

Just keep bumping the vote thread on a weekly bases... Thanks for your
patients.


-Matthias

On 10/19/18 1:08 AM, M. Manna wrote:
> Since this has gone quiet, could I prequest 1 more vote here - if anyone
> thinks it's worth doing?
> 
> Thanks,
> 
> 
> 
> On Wed, 3 Oct 2018 at 16:14, M. Manna <ma...@gmail.com> wrote:
> 
>> Thanks for reminding me about the "Binding" vote Bill. I remember some
>> people with non-binding vote, so jumped the gun a bit too early.
>> We will wait for 2 more as you stated.
>>
>> Regards,
>>
>> On Wed, 3 Oct 2018 at 16:07, Bill Bejeck <bb...@gmail.com> wrote:
>>
>>> +1 from me.
>>>
>>> As for closing the vote, it needs to be open for a minimum of 72 and
>>> requires three binding +1 votes.  Additionally, there needs more +1
>>> binding
>>> votes than -1 votes.  The description for the lazy majority vote process
>>> is
>>> described here
>>> https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals
>>> .
>>>
>>> I haven't been tracking the vote results, but from what I can see in the
>>> voting thread, this KIP still requires two more +1 binding votes.
>>>
>>> HTH,
>>> BIll
>>>
>>> On Wed, Oct 3, 2018 at 8:58 AM M. Manna <ma...@gmail.com> wrote:
>>>
>>>> Since this has been open for a while, I am assuming that it's good to
>>> go?
>>>>
>>>> if so, I will update the KIP page - and start coding this. I would
>>> prefer
>>>> re-using existing tests written for DefaultPartitioner, so that we don't
>>>> need to write new tests.
>>>>
>>>> Regards,
>>>>
>>>> On Sun, 30 Sep 2018 at 19:34, Matthias J. Sax <ma...@confluent.io>
>>>> wrote:
>>>>
>>>>> +1 (binding)
>>>>>
>>>>> @Abhimanyu: can you please update the table in
>>>>>
>>>>>
>>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
>>>>> and add a link to the KIP. Thanks.
>>>>>
>>>>> -Matthias
>>>>>
>>>>> On 9/4/18 9:56 PM, Abhimanyu Nagrath wrote:
>>>>>> +1
>>>>>>
>>>>>> On Wed, Sep 5, 2018 at 2:39 AM Magesh Nandakumar <
>>> mageshn@confluent.io
>>>>>
>>>>>> wrote:
>>>>>>
>>>>>>> +1 ( non-binding)
>>>>>>>
>>>>>>> On Tue, Sep 4, 2018 at 3:39 AM M. Manna <ma...@gmail.com>
>>> wrote:
>>>>>>>
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> I have made necessary changes as per the original discussion
>>> thread,
>>>>> and
>>>>>>>> would like to put it for votes.
>>>>>>>>
>>>>>>>> Thank you very much for your suggestion and guidance so far.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
> 


Re: [VOTE] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

Posted by "M. Manna" <ma...@gmail.com>.
Since this has gone quiet, could I prequest 1 more vote here - if anyone
thinks it's worth doing?

Thanks,



On Wed, 3 Oct 2018 at 16:14, M. Manna <ma...@gmail.com> wrote:

> Thanks for reminding me about the "Binding" vote Bill. I remember some
> people with non-binding vote, so jumped the gun a bit too early.
> We will wait for 2 more as you stated.
>
> Regards,
>
> On Wed, 3 Oct 2018 at 16:07, Bill Bejeck <bb...@gmail.com> wrote:
>
>> +1 from me.
>>
>> As for closing the vote, it needs to be open for a minimum of 72 and
>> requires three binding +1 votes.  Additionally, there needs more +1
>> binding
>> votes than -1 votes.  The description for the lazy majority vote process
>> is
>> described here
>> https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals
>> .
>>
>> I haven't been tracking the vote results, but from what I can see in the
>> voting thread, this KIP still requires two more +1 binding votes.
>>
>> HTH,
>> BIll
>>
>> On Wed, Oct 3, 2018 at 8:58 AM M. Manna <ma...@gmail.com> wrote:
>>
>> > Since this has been open for a while, I am assuming that it's good to
>> go?
>> >
>> > if so, I will update the KIP page - and start coding this. I would
>> prefer
>> > re-using existing tests written for DefaultPartitioner, so that we don't
>> > need to write new tests.
>> >
>> > Regards,
>> >
>> > On Sun, 30 Sep 2018 at 19:34, Matthias J. Sax <ma...@confluent.io>
>> > wrote:
>> >
>> > > +1 (binding)
>> > >
>> > > @Abhimanyu: can you please update the table in
>> > >
>> > >
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
>> > > and add a link to the KIP. Thanks.
>> > >
>> > > -Matthias
>> > >
>> > > On 9/4/18 9:56 PM, Abhimanyu Nagrath wrote:
>> > > > +1
>> > > >
>> > > > On Wed, Sep 5, 2018 at 2:39 AM Magesh Nandakumar <
>> mageshn@confluent.io
>> > >
>> > > > wrote:
>> > > >
>> > > >> +1 ( non-binding)
>> > > >>
>> > > >> On Tue, Sep 4, 2018 at 3:39 AM M. Manna <ma...@gmail.com>
>> wrote:
>> > > >>
>> > > >>> Hello,
>> > > >>>
>> > > >>> I have made necessary changes as per the original discussion
>> thread,
>> > > and
>> > > >>> would like to put it for votes.
>> > > >>>
>> > > >>> Thank you very much for your suggestion and guidance so far.
>> > > >>>
>> > > >>> Regards,
>> > > >>>
>> > > >>
>> > > >
>> > >
>> > >
>> >
>>
>

Re: [VOTE] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

Posted by "M. Manna" <ma...@gmail.com>.
Since this has gone quiet, could I prequest 1 more vote here - if anyone
thinks it's worth doing?

Thanks,



On Wed, 3 Oct 2018 at 16:14, M. Manna <ma...@gmail.com> wrote:

> Thanks for reminding me about the "Binding" vote Bill. I remember some
> people with non-binding vote, so jumped the gun a bit too early.
> We will wait for 2 more as you stated.
>
> Regards,
>
> On Wed, 3 Oct 2018 at 16:07, Bill Bejeck <bb...@gmail.com> wrote:
>
>> +1 from me.
>>
>> As for closing the vote, it needs to be open for a minimum of 72 and
>> requires three binding +1 votes.  Additionally, there needs more +1
>> binding
>> votes than -1 votes.  The description for the lazy majority vote process
>> is
>> described here
>> https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals
>> .
>>
>> I haven't been tracking the vote results, but from what I can see in the
>> voting thread, this KIP still requires two more +1 binding votes.
>>
>> HTH,
>> BIll
>>
>> On Wed, Oct 3, 2018 at 8:58 AM M. Manna <ma...@gmail.com> wrote:
>>
>> > Since this has been open for a while, I am assuming that it's good to
>> go?
>> >
>> > if so, I will update the KIP page - and start coding this. I would
>> prefer
>> > re-using existing tests written for DefaultPartitioner, so that we don't
>> > need to write new tests.
>> >
>> > Regards,
>> >
>> > On Sun, 30 Sep 2018 at 19:34, Matthias J. Sax <ma...@confluent.io>
>> > wrote:
>> >
>> > > +1 (binding)
>> > >
>> > > @Abhimanyu: can you please update the table in
>> > >
>> > >
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
>> > > and add a link to the KIP. Thanks.
>> > >
>> > > -Matthias
>> > >
>> > > On 9/4/18 9:56 PM, Abhimanyu Nagrath wrote:
>> > > > +1
>> > > >
>> > > > On Wed, Sep 5, 2018 at 2:39 AM Magesh Nandakumar <
>> mageshn@confluent.io
>> > >
>> > > > wrote:
>> > > >
>> > > >> +1 ( non-binding)
>> > > >>
>> > > >> On Tue, Sep 4, 2018 at 3:39 AM M. Manna <ma...@gmail.com>
>> wrote:
>> > > >>
>> > > >>> Hello,
>> > > >>>
>> > > >>> I have made necessary changes as per the original discussion
>> thread,
>> > > and
>> > > >>> would like to put it for votes.
>> > > >>>
>> > > >>> Thank you very much for your suggestion and guidance so far.
>> > > >>>
>> > > >>> Regards,
>> > > >>>
>> > > >>
>> > > >
>> > >
>> > >
>> >
>>
>

Re: [VOTE] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

Posted by "M. Manna" <ma...@gmail.com>.
Thanks for reminding me about the "Binding" vote Bill. I remember some
people with non-binding vote, so jumped the gun a bit too early.
We will wait for 2 more as you stated.

Regards,

On Wed, 3 Oct 2018 at 16:07, Bill Bejeck <bb...@gmail.com> wrote:

> +1 from me.
>
> As for closing the vote, it needs to be open for a minimum of 72 and
> requires three binding +1 votes.  Additionally, there needs more +1 binding
> votes than -1 votes.  The description for the lazy majority vote process is
> described here
> https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals.
>
> I haven't been tracking the vote results, but from what I can see in the
> voting thread, this KIP still requires two more +1 binding votes.
>
> HTH,
> BIll
>
> On Wed, Oct 3, 2018 at 8:58 AM M. Manna <ma...@gmail.com> wrote:
>
> > Since this has been open for a while, I am assuming that it's good to go?
> >
> > if so, I will update the KIP page - and start coding this. I would prefer
> > re-using existing tests written for DefaultPartitioner, so that we don't
> > need to write new tests.
> >
> > Regards,
> >
> > On Sun, 30 Sep 2018 at 19:34, Matthias J. Sax <ma...@confluent.io>
> > wrote:
> >
> > > +1 (binding)
> > >
> > > @Abhimanyu: can you please update the table in
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
> > > and add a link to the KIP. Thanks.
> > >
> > > -Matthias
> > >
> > > On 9/4/18 9:56 PM, Abhimanyu Nagrath wrote:
> > > > +1
> > > >
> > > > On Wed, Sep 5, 2018 at 2:39 AM Magesh Nandakumar <
> mageshn@confluent.io
> > >
> > > > wrote:
> > > >
> > > >> +1 ( non-binding)
> > > >>
> > > >> On Tue, Sep 4, 2018 at 3:39 AM M. Manna <ma...@gmail.com> wrote:
> > > >>
> > > >>> Hello,
> > > >>>
> > > >>> I have made necessary changes as per the original discussion
> thread,
> > > and
> > > >>> would like to put it for votes.
> > > >>>
> > > >>> Thank you very much for your suggestion and guidance so far.
> > > >>>
> > > >>> Regards,
> > > >>>
> > > >>
> > > >
> > >
> > >
> >
>

Re: [VOTE] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

Posted by Bill Bejeck <bb...@gmail.com>.
+1 from me.

As for closing the vote, it needs to be open for a minimum of 72 and
requires three binding +1 votes.  Additionally, there needs more +1 binding
votes than -1 votes.  The description for the lazy majority vote process is
described here
https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals.

I haven't been tracking the vote results, but from what I can see in the
voting thread, this KIP still requires two more +1 binding votes.

HTH,
BIll

On Wed, Oct 3, 2018 at 8:58 AM M. Manna <ma...@gmail.com> wrote:

> Since this has been open for a while, I am assuming that it's good to go?
>
> if so, I will update the KIP page - and start coding this. I would prefer
> re-using existing tests written for DefaultPartitioner, so that we don't
> need to write new tests.
>
> Regards,
>
> On Sun, 30 Sep 2018 at 19:34, Matthias J. Sax <ma...@confluent.io>
> wrote:
>
> > +1 (binding)
> >
> > @Abhimanyu: can you please update the table in
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
> > and add a link to the KIP. Thanks.
> >
> > -Matthias
> >
> > On 9/4/18 9:56 PM, Abhimanyu Nagrath wrote:
> > > +1
> > >
> > > On Wed, Sep 5, 2018 at 2:39 AM Magesh Nandakumar <mageshn@confluent.io
> >
> > > wrote:
> > >
> > >> +1 ( non-binding)
> > >>
> > >> On Tue, Sep 4, 2018 at 3:39 AM M. Manna <ma...@gmail.com> wrote:
> > >>
> > >>> Hello,
> > >>>
> > >>> I have made necessary changes as per the original discussion thread,
> > and
> > >>> would like to put it for votes.
> > >>>
> > >>> Thank you very much for your suggestion and guidance so far.
> > >>>
> > >>> Regards,
> > >>>
> > >>
> > >
> >
> >
>