You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/05/07 03:33:49 UTC
Review Request: Fixed the resource monitor output upon collection failure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10967/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See the bug description. The fix is the added parens in monitor.cpp.
This addresses bug MESOS-462.
https://issues.apache.org/jira/browse/MESOS-462
Diffs
-----
src/slave/cgroups_isolator.cpp f12fd48fe739015429a3fe51cc8dce366ec4a483
src/slave/monitor.cpp e038c2c5bf4cf5dcda8a91c46505c228e7d65ebd
Diff: https://reviews.apache.org/r/10967/diff/
Testing
-------
Verified output with make check. Managed to reproduce using the BalloonFramework test.
Thanks,
Ben Mahler
Re: Review Request: Fixed the resource monitor output upon collection
failure.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10967/#review20247
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 7, 2013, 1:33 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10967/
> -----------------------------------------------------------
>
> (Updated May 7, 2013, 1:33 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See the bug description. The fix is the added parens in monitor.cpp.
>
>
> This addresses bug MESOS-462.
> https://issues.apache.org/jira/browse/MESOS-462
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp f12fd48fe739015429a3fe51cc8dce366ec4a483
> src/slave/monitor.cpp e038c2c5bf4cf5dcda8a91c46505c228e7d65ebd
>
> Diff: https://reviews.apache.org/r/10967/diff/
>
>
> Testing
> -------
>
> Verified output with make check. Managed to reproduce using the BalloonFramework test.
>
>
> Thanks,
>
> Ben Mahler
>
>