You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2020/09/28 16:24:00 UTC

[jira] [Commented] (ARROW-9421) [C++][Parquet] Redundancies SchemaManifest::GetFieldIndices

    [ https://issues.apache.org/jira/browse/ARROW-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203343#comment-17203343 ] 

Antoine Pitrou commented on ARROW-9421:
---------------------------------------

I'm not sure what the redundancies are exactly, reading the GH discussion, but this looks extremely minor?

> [C++][Parquet] Redundancies SchemaManifest::GetFieldIndices
> -----------------------------------------------------------
>
>                 Key: ARROW-9421
>                 URL: https://issues.apache.org/jira/browse/ARROW-9421
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.17.1
>            Reporter: Ben Kietzman
>            Priority: Major
>             Fix For: 3.0.0
>
>
> Discussion: https://github.com/apache/arrow/pull/7704#discussion_r453224951
> It might be worthwhile to provide {{int SchemaDescriptor::GetColumnRootIndex(column_idx)}} and to replace assertions in {{parquet/schema.cc}} with null returns or so



--
This message was sent by Atlassian Jira
(v8.3.4#803005)