You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by su...@apache.org on 2015/01/10 06:16:07 UTC

trafficserver git commit: Fix the Resource leak in error case

Repository: trafficserver
Updated Branches:
  refs/heads/master 8d5044201 -> e50c0d609


Fix the Resource leak in error case

Coverity CID#1254816


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/e50c0d60
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/e50c0d60
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/e50c0d60

Branch: refs/heads/master
Commit: e50c0d609f58b5497dcf29d293b5924e49e83fa5
Parents: 8d50442
Author: Sudheer Vinukonda <su...@yahoo-inc.com>
Authored: Sat Jan 10 05:14:40 2015 +0000
Committer: Sudheer Vinukonda <su...@yahoo-inc.com>
Committed: Sat Jan 10 05:14:40 2015 +0000

----------------------------------------------------------------------
 proxy/http2/HPACK.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e50c0d60/proxy/http2/HPACK.cc
----------------------------------------------------------------------
diff --git a/proxy/http2/HPACK.cc b/proxy/http2/HPACK.cc
index e4e3a64..2ef5083 100644
--- a/proxy/http2/HPACK.cc
+++ b/proxy/http2/HPACK.cc
@@ -602,7 +602,10 @@ decode_literal_header_field(MIMEFieldWrapper& header, const uint8_t *buf_start,
   char *c_value = NULL;
   uint32_t c_value_len = 0;
   len = decode_string(&c_value, c_value_len, p, buf_end);
-  if (len == -1) return -1;
+  if (len == -1) {
+    ats_free(c_value);
+    return -1;
+  }
   p += len;
   header.value_set(c_value, c_value_len);
   ats_free(c_value);