You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "flycash (GitHub)" <gi...@apache.org> on 2020/02/05 03:23:20 UTC

[GitHub] [dubbo-go] flycash opened pull request #352: (WIP) Rest protocol

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:
Provide rest protocol implementation

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
Support rest protocol. 
```

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/932e14956a1f7adb91796afd545312d9fab73281?src=pr&el=desc) will **increase** coverage by `2.68%`.
> The diff coverage is `74.7%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    66.51%   69.19%   +2.68%     
===========================================
  Files          113      171      +58     
  Lines         7268     9697    +2429     
===========================================
+ Hits          4834     6710    +1876     
- Misses        1953     2382     +429     
- Partials       481      605     +124
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/jsonrpc/jsonrpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX3Byb3RvY29sLmdv) | `91.83% <ø> (ø)` | :arrow_up: |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0% <ø> (ø)` | |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `72.34% <ø> (-18.14%)` | :arrow_down: |
| [protocol/protocolwrapper/mock\_protocol\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL21vY2tfcHJvdG9jb2xfZmlsdGVyLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/registry\_aware\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvcmVnaXN0cnlfYXdhcmVfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [protocol/jsonrpc/json.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29uLmdv) | `52.94% <ø> (ø)` | :arrow_up: |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0% <ø> (ø)` | |
| ... and [228 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [932e149...84a2b65](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
as above

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on issue #352: Rest protocol

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
@Patrick0308 
Rest should have its own configuration, however, some dubbo's public configuration, such as the registry, should not have different loading. If there are different loading methods, I think it is better to extend config instead of rest


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
as above

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #352: Rest protocol

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
		serverMap:    make(map[string]rest_interface.RestServer, 8),
		clientMap:    make(map[rest_interface.RestOptions]rest_interface.RestClient, 8),

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt closed pull request #352: Rest protocol

Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
[ pull request closed by hxmhlt ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
This function set default value

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/932e14956a1f7adb91796afd545312d9fab73281?src=pr&el=desc) will **increase** coverage by `0.24%`.
> The diff coverage is `71.9%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    66.51%   66.75%   +0.24%     
===========================================
  Files          113      158      +45     
  Lines         7268     8230     +962     
===========================================
+ Hits          4834     5494     +660     
- Misses        1953     2210     +257     
- Partials       481      526      +45
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/jsonrpc/jsonrpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX3Byb3RvY29sLmdv) | `91.83% <ø> (ø)` | :arrow_up: |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `70.27% <ø> (-5.41%)` | :arrow_down: |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0% <ø> (ø)` | |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `90.47% <ø> (ø)` | :arrow_up: |
| [protocol/protocolwrapper/mock\_protocol\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL21vY2tfcHJvdG9jb2xfZmlsdGVyLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/registry\_aware\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvcmVnaXN0cnlfYXdhcmVfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [protocol/jsonrpc/json.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29uLmdv) | `52.94% <ø> (ø)` | :arrow_up: |
| ... and [194 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [932e149...4738480](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.56%`.
> The diff coverage is `72.59%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.03%   67.59%   +0.56%     
===========================================
  Files          161      169       +8     
  Lines         8331     8580     +249     
===========================================
+ Hits          5585     5800     +215     
- Misses        2222     2240      +18     
- Partials       524      540      +16
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (+0.98%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <100%> (ø)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <50%> (+7.16%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `58.06% <50%> (ø)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...46af97f](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on issue #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
@fangyincheng  rest_config and other_config are may be in different places. For example, other_config is in a yml, rest_config may be in code.
![image](https://user-images.githubusercontent.com/5486149/76484457-cc8c5200-6454-11ea-8fac-8828a02d023d.png)


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #352: Rest protocol

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
this func declaration is so long. pls change it as follows:

func getFunc(methodName string, 
                        invoker protocol.Invoker,

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.59%`.
> The diff coverage is `71.32%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.03%   67.63%   +0.59%     
===========================================
  Files          161      170       +9     
  Lines         8331     8655     +324     
===========================================
+ Hits          5585     5854     +269     
- Misses        2222     2256      +34     
- Partials       524      545      +21
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (+0.98%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | |
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <100%> (ø)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `63.71% <100%> (+1.33%)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...8c53128](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
split package

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #352: Rest protocol

Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
ok

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
I don't use this tools. I will remove this.

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
`GetRestyClient` will return `rest_interface.RestClient` and `NewRestyClient` will return `*RestyClient`

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #352: Rest protocol

Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
file name error

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on pull request #352: Rest protocol

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
format

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #352: Rest protocol

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
restServers = make(map[string]func() rest_interface.RestServer, 32)

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #352: Rest protocol

Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
ok

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.6%`.
> The diff coverage is `73.66%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           develop     #352     +/-   ##
==========================================
+ Coverage    67.03%   67.64%   +0.6%     
==========================================
  Files          161      170      +9     
  Lines         8331     8591    +260     
==========================================
+ Hits          5585     5811    +226     
- Misses        2222     2240     +18     
- Partials       524      540     +16
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (+0.98%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | |
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <100%> (ø)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <50%> (+7.16%)` | :arrow_up: |
| ... and [21 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...46af97f](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a4c9d8c10304ece141881dbe66bd96357b498822&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@           Coverage Diff            @@
##           develop     #352   +/-   ##
========================================
  Coverage    67.47%   67.47%           
========================================
  Files          169      169           
  Lines         8579     8579           
========================================
  Hits          5789     5789           
  Misses        2246     2246           
  Partials       544      544           
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a4c9d8c...a4c9d8c](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #352: Rest protocol

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls using it in defer style

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/932e14956a1f7adb91796afd545312d9fab73281?src=pr&el=desc) will **increase** coverage by `1.09%`.
> The diff coverage is `74.58%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           develop    #352      +/-   ##
==========================================
+ Coverage    66.51%   67.6%   +1.09%     
==========================================
  Files          113     158      +45     
  Lines         7268    8353    +1085     
==========================================
+ Hits          4834    5647     +813     
- Misses        1953    2180     +227     
- Partials       481     526      +45
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/jsonrpc/jsonrpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX3Byb3RvY29sLmdv) | `91.83% <ø> (ø)` | :arrow_up: |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `75.67% <ø> (ø)` | :arrow_up: |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0% <ø> (ø)` | |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `90.47% <ø> (ø)` | :arrow_up: |
| [protocol/protocolwrapper/mock\_protocol\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL21vY2tfcHJvdG9jb2xfZmlsdGVyLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/registry\_aware\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvcmVnaXN0cnlfYXdhcmVfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [protocol/jsonrpc/json.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29uLmdv) | `52.94% <ø> (ø)` | :arrow_up: |
| ... and [192 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [932e149...4b01d83](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `2.15%`.
> The diff coverage is `70.96%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.03%   69.19%   +2.15%     
===========================================
  Files          161      171      +10     
  Lines         8331     9697    +1366     
===========================================
+ Hits          5585     6710    +1125     
- Misses        2222     2382     +160     
- Partials       524      605      +81
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `60.25% <ø> (+4.93%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `67.34% <0%> (+9.28%)` | :arrow_up: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `70.18% <100%> (+12.92%)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [...l/rest/rest\_config\_reader/default\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2NvbmZpZ19yZWFkZXIvZGVmYXVsdF9jb25maWdfcmVhZGVyLmdv) | `45.45% <45.45%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.5% <50%> (-2.21%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...73119b4](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/085b9158110f1fe835f5ae5a57aa72384efcc09d?src=pr&el=desc) will **increase** coverage by `0.43%`.
> The diff coverage is `68.65%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.09%   67.52%   +0.43%     
===========================================
  Files          161      169       +8     
  Lines         8333     8579     +246     
===========================================
+ Hits          5591     5793     +202     
- Misses        2217     2243      +26     
- Partials       525      543      +18
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (+0.98%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [common/extension/confit\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maXRfcmVhZGVyLmdv) | `0% <0%> (ø)` | |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | |
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <100%> (ø)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `56.91% <14.28%> (-5.48%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [085b915...7e7dfdb](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.62%`.
> The diff coverage is `71.32%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.03%   67.66%   +0.62%     
===========================================
  Files          161      170       +9     
  Lines         8331     8651     +320     
===========================================
+ Hits          5585     5854     +269     
- Misses        2222     2252      +30     
- Partials       524      545      +21
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (+0.98%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | |
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <100%> (ø)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `63.71% <100%> (+1.33%)` | :arrow_up: |
| ... and [25 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...dafc2f4](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
as above

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/932e14956a1f7adb91796afd545312d9fab73281?src=pr&el=desc) will **increase** coverage by `1.09%`.
> The diff coverage is `74.58%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           develop    #352      +/-   ##
==========================================
+ Coverage    66.51%   67.6%   +1.09%     
==========================================
  Files          113     158      +45     
  Lines         7268    8353    +1085     
==========================================
+ Hits          4834    5647     +813     
- Misses        1953    2180     +227     
- Partials       481     526      +45
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/jsonrpc/jsonrpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX3Byb3RvY29sLmdv) | `91.83% <ø> (ø)` | :arrow_up: |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `75.67% <ø> (ø)` | :arrow_up: |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0% <ø> (ø)` | |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `90.47% <ø> (ø)` | :arrow_up: |
| [protocol/protocolwrapper/mock\_protocol\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL21vY2tfcHJvdG9jb2xfZmlsdGVyLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/registry\_aware\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvcmVnaXN0cnlfYXdhcmVfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [protocol/jsonrpc/json.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29uLmdv) | `52.94% <ø> (ø)` | :arrow_up: |
| ... and [192 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [932e149...4738480](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a4c9d8c10304ece141881dbe66bd96357b498822&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@           Coverage Diff            @@
##           develop     #352   +/-   ##
========================================
  Coverage    67.47%   67.47%           
========================================
  Files          169      169           
  Lines         8579     8579           
========================================
  Hits          5789     5789           
  Misses        2246     2246           
  Partials       544      544           
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a4c9d8c...a4c9d8c](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.59%`.
> The diff coverage is `71.32%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.03%   67.63%   +0.59%     
===========================================
  Files          161      170       +9     
  Lines         8331     8655     +324     
===========================================
+ Hits          5585     5854     +269     
- Misses        2222     2256      +34     
- Partials       524      545      +21
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (+0.98%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | |
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <100%> (ø)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `63.71% <100%> (+1.33%)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...8c53128](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.62%`.
> The diff coverage is `71.32%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.03%   67.66%   +0.62%     
===========================================
  Files          161      170       +9     
  Lines         8331     8651     +320     
===========================================
+ Hits          5585     5854     +269     
- Misses        2222     2252      +30     
- Partials       524      545      +21
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (+0.98%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | |
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <100%> (ø)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `63.71% <100%> (+1.33%)` | :arrow_up: |
| ... and [25 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...8c53128](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #352: Rest protocol

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
so long if condition. pls split it into multiple lines.

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.56%`.
> The diff coverage is `72.59%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.03%   67.59%   +0.56%     
===========================================
  Files          161      169       +8     
  Lines         8331     8580     +249     
===========================================
+ Hits          5585     5800     +215     
- Misses        2222     2240      +18     
- Partials       524      540      +16
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (+0.98%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [config/condition\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmRpdGlvbl9yb3V0ZXJfY29uZmlnLmdv) | `84.61% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `57.26% <100%> (ø)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <50%> (+7.16%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `58.06% <50%> (ø)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...73119b4](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
I think adding a yaml package in common is better.

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #352: Rest protocol

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls using it in defer style

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
RestfulServer is like to the interface `RestServer`. This server is implement by go-restful. May be this name is better.

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
split package

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
split

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
Before server and client are being destroyed, we have destroyed the invoker and exporter in `BaseProtocol.Destroy()`. 

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
apache lisence

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
merge this block to  above

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8c53128d36cf96fe20b95281ff708fc37aa59be4&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@           Coverage Diff            @@
##           develop     #352   +/-   ##
========================================
  Coverage    67.63%   67.63%           
========================================
  Files          170      170           
  Lines         8655     8655           
========================================
  Hits          5854     5854           
  Misses        2256     2256           
  Partials       545      545           
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [8c53128...8c53128](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
this if condition clause is so long. pls change it as follows,

if ok {
return restServer
}

xxxxx

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `2.15%`.
> The diff coverage is `70.96%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    67.03%   69.19%   +2.15%     
===========================================
  Files          161      171      +10     
  Lines         8331     9697    +1366     
===========================================
+ Hits          5585     6710    +1125     
- Misses        2222     2382     +160     
- Partials       524      605      +81
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `60.25% <ø> (+4.93%)` | :arrow_up: |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/rest\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X3NlcnZlci5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NsaWVudC5nbw==) | `0% <0%> (ø)` | |
| [common/extension/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9yZXN0X2NvbmZpZ19yZWFkZXIuZ28=) | `0% <0%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `67.34% <0%> (+9.28%)` | :arrow_up: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `70.18% <100%> (+12.92%)` | :arrow_up: |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `100% <100%> (ø)` | |
| [...l/rest/rest\_config\_reader/default\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2NvbmZpZ19yZWFkZXIvZGVmYXVsdF9jb25maWdfcmVhZGVyLmdv) | `45.45% <45.45%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.5% <50%> (-2.21%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [a7ae33f...f8f2b56](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #352: Rest protocol

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/932e14956a1f7adb91796afd545312d9fab73281?src=pr&el=desc) will **increase** coverage by `2.68%`.
> The diff coverage is `74.7%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/352/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    66.51%   69.19%   +2.68%     
===========================================
  Files          113      171      +58     
  Lines         7268     9697    +2429     
===========================================
+ Hits          4834     6710    +1876     
- Misses        1953     2382     +429     
- Partials       481      605     +124
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/jsonrpc/jsonrpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX3Byb3RvY29sLmdv) | `91.83% <ø> (ø)` | :arrow_up: |
| [config\_center/configurator/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3IvbW9jay5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0% <ø> (ø)` | |
| [cluster/directory/static\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3Rvcnkvc3RhdGljX2RpcmVjdG9yeS5nbw==) | `72.34% <ø> (-18.14%)` | :arrow_down: |
| [protocol/protocolwrapper/mock\_protocol\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL21vY2tfcHJvdG9jb2xfZmlsdGVyLmdv) | `0% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [cluster/cluster\_impl/registry\_aware\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvcmVnaXN0cnlfYXdhcmVfY2x1c3Rlci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [protocol/jsonrpc/json.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29uLmdv) | `52.94% <ø> (ø)` | :arrow_up: |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0% <ø> (ø)` | |
| ... and [228 more](https://codecov.io/gh/apache/dubbo-go/pull/352/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=footer). Last update [932e149...84a2b65](https://codecov.io/gh/apache/dubbo-go/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
Is it useful now? if not delete it.

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #352: Rest protocol

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
make(map[string]string, 0)? if so, u can change it to `make(map[string]string)`

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #352: Rest protocol

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
fix

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on pull request #352: Rest protocol

Posted by "zouyx (GitHub)" <gi...@apache.org>.
```suggestion
	if restConsumerConfig == nil || len(restConsumerConfig.RestConfigMap)==0{
```
i think ``` len(restConsumerConfig.RestConfigMap)==0`` no need to run  the following code

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #352: Rest protocol

Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
Why named GoRestfulServer but not RestfulServer?

[ Full content available at: https://github.com/apache/dubbo-go/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org