You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/11 09:33:36 UTC

[GitHub] JulieRossi commented on issue #3441: config: allow choosing separator character and encoding for csv writing

JulieRossi commented on issue #3441: config: allow choosing separator character and encoding for csv writing
URL: https://github.com/apache/incubator-superset/pull/3441#issuecomment-328475048
 
 
   `test_csv_endpoint` (https://github.com/apache/incubator-superset/blob/master/tests/core_tests.py#L527)
   tests csv export route (https://github.com/apache/incubator-superset/blob/master/superset/views/core.py#L2102)
   
   `test_slice_csv_endpoint` (https://github.com/apache/incubator-superset/blob/master/tests/core_tests.py#L92)
   tests csv export from slice (https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L306)
   
   So both cases are already tested.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services