You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2017/08/08 11:44:41 UTC

[GitHub] carbondata pull request #1246: [CARBONDATA-1367] Change module dependency fr...

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/1246

    [CARBONDATA-1367] Change module dependency from spark1 to spark2

    # Problems
    When compiling Carbondata with profile spark-2.1, `carbondata-examples-flink` will be compiled too. But this module depends on `carbondata-example-spark` and `sparkdata-spark` which will be compiled with profile-1.6, so we need to fix it.
    
    # Solution
    + Change module dependency from spark1 to spark2.
    
    + Copy the `ExampleUtils.scala` from `carbondata-examples-spark` to ``carbondata-examples-spark2` and replace `CarbonContext` with `CarbonSession`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1246
    
----
commit 5b234ab400a611aca8ef50b4abc5d88cef8897b4
Author: xuchuanyin <xu...@hust.edu.cn>
Date:   2017-08-08T11:32:57Z

    [CARBONDATA-1367] Change dependency to spark2

commit 20e86e8c2ccf3f5acbfe987c2e53f7fd389ccf9d
Author: xuchuanyin <xu...@hust.edu.cn>
Date:   2017-08-08T11:38:10Z

    [CARBONDATA-1367] create utils for flink testcase

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #1246: [CARBONDATA-1367] Change module dependency from spar...

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1246
  
    This problem has already been solved by @chenliang613 in https://github.com/apache/carbondata/pull/1232/commits/fd8299497f68c1e7307450e321e761913a817788 by moving `example-flink` from spark-2.1 to spark-1.6/spark1.5.
    
    So just close this PR.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #1246: [CARBONDATA-1367] Change module dependency fr...

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin closed the pull request at:

    https://github.com/apache/carbondata/pull/1246


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata issue #1246: [CARBONDATA-1367] Change module dependency from spar...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1246
  
    SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/145/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---