You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 11:47:29 UTC

[GitHub] [flink] aljoscha commented on pull request #13676: [FLINK-19326][cep] Allow explicitly configuring time behaviour on CEP PatternStream

aljoscha commented on pull request #13676:
URL: https://github.com/apache/flink/pull/13676#issuecomment-716496084


   @SteNicholas Thanks for your work! I pushed some changes to your branch, I hope that's ok. I split the unrelated changes that remove imports. I also fixed the `PatternStreamBuilder`, the problem with the code before was that the time characteristic would be dropped when calling the builder methods that don't call the right constructor. And I changed `DataStreamMatch` to use an explicit type instead of a boolean, because it's hard to parse what they mean when looking at the code in passing.
   
   Please let me know if you're ok with the changed, then I'd merge once CI is green.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org