[jira] [Commented] (JSPWIKI-1146) Add AWS Kendra as a Search Provider

["Juan Pablo Santos Rodríguez (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JSPWIKI-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17288047#comment-17288047 ] 

Juan Pablo Santos Rodríguez commented on JSPWIKI-1146:
------------------------------------------------------

Hi Julien,

thanks for your time & interest in JSPWiki! :-)

A Pull Request would be enough to begin getting the provider into JSPWiki.

After a quick look-through the code, some comments/nitpicks below:
 * the {{aws-java-sdk-kendra}} library and it dependencies are Apache Licensed (the don't include a LICENSE file, but examining source code you can see the headers). As such, the [LICENSE|https://github.com/apache/jspwiki/blob/master/LICENSE] file should be updated accordingly (see end of that file).
 * All dependencies are defined on the {{dependenciesManagement}} section of the project's parent pom, so they can be referred afterwards using only {{groupId}} + {{artifactId}}. All versions are set through their corresponding property on that file too, which are alphabetically sorted (so they're easier to find later on)
 * The {{Dockerfile}} included is not necessary, as the provider will be picked up by the war module, so the original {{Dockerfile}} should be enough..
 * Instructions on the {{README.md}} file should be a page at jspwiki-wiki.apache.org, like f.ex., [https://jspwiki-wiki.apache.org/Wiki.jsp?page=TikaSearchProvider]
 * The {{index-and-datasource.yaml}} and {{content_types.json}} are missing their Apache License header
 * The unit tests are very much welcome!


thx,
juan pablo

> Add AWS Kendra as a Search Provider
> -----------------------------------
>
>                 Key: JSPWIKI-1146
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1146
>             Project: JSPWiki
>          Issue Type: New Feature
>          Components: Search
>    Affects Versions: 2.11.0-M8
>            Reporter: Julien Masnada
>            Priority: Minor
>              Labels: features, pull-request-available
>
> We use AWS Kendra a central search tool in our organization to provide a search result that can span different Data Source (DB, Sharepoint, etc).
> Since we have a lot of documents in our Wiki, it is interesting for us to be able to index (in Kendra) and search pages and attachments from our wiki.
> Furthermore it is important to be able to search in attachments that are in PDF / Word / PPT or HTML format also.
> We have implemented a SearchProvider that does the job of indexing and returning search result. The code is available in [https://github.com/rostskadat/jspwiki]
> Some further documentation is available in the README.
> I would appreciate if you could direct me toward a document explaining the process for requesting the inclusion of this feature
> Thanks
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)