You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 07:29:47 UTC
[GitHub] [arrow-rs] gsserge opened a new issue #1328: Fix cvs Writer::new to accept delimiter and make WriterBuilder::build use it
gsserge opened a new issue #1328:
URL: https://github.com/apache/arrow-rs/issues/1328
Discovered in https://github.com/apache/arrow-rs/pull/1324#discussion_r808432375
The delimiter can be correctly configured via `WriterBuilder`. `WriterBuilder::build()` constructs the `Writer` in-line and does not use `Write::new()`.
Currently, `Write::new()` does not have the ability to configure the delimiter. The function should be changed to accept it as a parameter, and then `WriterBuilder::build()` should use `Write::new()` instead of duplicating the code. The `delimiter` field in `struct Writer` can be removed, because it can only be configured when creating `Writer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on issue #1328: Fix cvs Writer::new to accept delimiter and make WriterBuilder::build use it
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on issue #1328:
URL: https://github.com/apache/arrow-rs/issues/1328#issuecomment-1043714206
Just a small nit. The title should be `Fix CSV` not `Fix cvs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 edited a comment on issue #1328: Fix cvs Writer::new to accept delimiter and make WriterBuilder::build use it
Posted by GitBox <gi...@apache.org>.
HaoYang670 edited a comment on issue #1328:
URL: https://github.com/apache/arrow-rs/issues/1328#issuecomment-1043714206
Just a small nit. The title should be `Fix CSV` not `Fix cvs`.
Also, same mistake is in the title of https://github.com/apache/arrow-rs/issues/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me closed issue #1328: Fix csv Writer::new to accept delimiter and make WriterBuilder::build use it
Posted by GitBox <gi...@apache.org>.
nevi-me closed issue #1328:
URL: https://github.com/apache/arrow-rs/issues/1328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org