You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sis.apache.org by Martin Desruisseaux <ma...@geomatys.fr> on 2013/05/31 00:02:21 UTC
Proposal to move QuadTree and GeoRSSData in their own packages
Hello all
I'm putting some basic blocks in the "org.apache.sis.storage" package,
proposed as the basis of storage formats in SIS. For now:
- DataStore
- DataStoreConnection
- DataStoreException
A NetcdfDataStore will be committed later in the "netcdf" sub-package.
However the QuadTree and GeoRSSData are currently living in the same
package, while I think they could be considered as specializations. What
about the following move?
- QuadTree and related classes to "org.apache.sis.storage.index" or
just "org.apache.sis.index"
- GeoRSSData in "org.apache.sis.storage.rss"
However this would be an incompatible change for Apache SIS 0.2 users...
What do peoples think?
Martin
Re: Proposal to move QuadTree and GeoRSSData in their own packages
Posted by Martin Desruisseaux <ma...@geomatys.fr>.
Hello Adam
Le 31/05/13 00:11, Adam Estrada a écrit :
> I think its completely acceptable to move this now before the next major
> release. I do think that we need to consider changing the name "index"
> though as we may want to incorporate different types of indices later down
> the road.
Indeed, I think we will have at least QuadTree and RTree (possibly more
than one variant of RTree). However I don't know yet if each index would
have basically one public class (ignoring package-privated classes) or
many. If each index has only one public class, we could be in a
situation similar to java.util.Collection where various implementations
are in the same package without (I think) confusion.
> GeoRSS will ways be GeoRSS except with different flavors of the
> RSS spec (ATOM too for that matter). I think in that case the same package
> can hold those as subpackages.
>
> +1 for the move and if 0.2 users have issues, we can walk them through the
> changes here.
Thanks. I will wait a few days before the move, to leave more
opportunity for feedbacks.
Martin
Re: Proposal to move QuadTree and GeoRSSData in their own packages
Posted by Martin Desruisseaux <ma...@geomatys.fr>.
Hello all
Following on that proposal, I filled SIS-101 and moved QuadTree and
GeoRSSData to their own package, namely "org.apache.sis.index.tree". At
first, I was considering moving GeoRSSData to an other package on the
assumption that it was a storage format, but then I realized that it was
rather an implementation of QuadTreeData for work with quad-tree, so I
left it in the same package than QuadTree. This would also reduce the
amount of changes for the users.
If anyone suggest an other package name, please let me known. I also
moved the classes from the "sis-referencing" to "sis-storage" module,
since they seem more storage related to me (admittedly, index could sit
somewhere between referencing and storage...)
Martin
[1] https://issues.apache.org/jira/browse/SIS-101
Le 31/05/13 00:11, Adam Estrada a écrit :
> Hey Martin,
>
> I think its completely acceptable to move this now before the next major
> release. I do think that we need to consider changing the name "index"
> though as we may want to incorporate different types of indices later down
> the road. GeoRSS will ways be GeoRSS except with different flavors of the
> RSS spec (ATOM too for that matter). I think in that case the same package
> can hold those as subpackages.
>
> +1 for the move and if 0.2 users have issues, we can walk them through the
> changes here.
>
> Adam
>
>
> On Thu, May 30, 2013 at 6:02 PM, Martin Desruisseaux <
> martin.desruisseaux@geomatys.fr> wrote:
>> Hello all
>>
>> I'm putting some basic blocks in the "org.apache.sis.storage" package,
>> proposed as the basis of storage formats in SIS. For now:
>>
>> - DataStore
>> - DataStoreConnection
>> - DataStoreException
>>
>> A NetcdfDataStore will be committed later in the "netcdf" sub-package.
>> However the QuadTree and GeoRSSData are currently living in the same
>> package, while I think they could be considered as specializations. What
>> about the following move?
>>
>> - QuadTree and related classes to "org.apache.sis.storage.index" or just
>> "org.apache.sis.index"
>> - GeoRSSData in "org.apache.sis.storage.rss"
>>
>> However this would be an incompatible change for Apache SIS 0.2 users...
>> What do peoples think?
>>
>> Martin
Re: Proposal to move QuadTree and GeoRSSData in their own packages
Posted by Adam Estrada <es...@gmail.com>.
Hey Martin,
I think its completely acceptable to move this now before the next major
release. I do think that we need to consider changing the name "index"
though as we may want to incorporate different types of indices later down
the road. GeoRSS will ways be GeoRSS except with different flavors of the
RSS spec (ATOM too for that matter). I think in that case the same package
can hold those as subpackages.
+1 for the move and if 0.2 users have issues, we can walk them through the
changes here.
Adam
On Thu, May 30, 2013 at 6:02 PM, Martin Desruisseaux <
martin.desruisseaux@geomatys.fr> wrote:
> Hello all
>
> I'm putting some basic blocks in the "org.apache.sis.storage" package,
> proposed as the basis of storage formats in SIS. For now:
>
> - DataStore
> - DataStoreConnection
> - DataStoreException
>
> A NetcdfDataStore will be committed later in the "netcdf" sub-package.
> However the QuadTree and GeoRSSData are currently living in the same
> package, while I think they could be considered as specializations. What
> about the following move?
>
> - QuadTree and related classes to "org.apache.sis.storage.index" or just
> "org.apache.sis.index"
> - GeoRSSData in "org.apache.sis.storage.rss"
>
> However this would be an incompatible change for Apache SIS 0.2 users...
> What do peoples think?
>
> Martin
>
>