[jira] Issue Comment Edited: (DERBY-4314) With derby client setTransactionIsolation executes and commits even if isolation has not changed

["Kathey Marsden (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734793#action_12734793 ] 

Kathey Marsden edited comment on DERBY-4314 at 7/23/09 2:27 PM:
----------------------------------------------------------------

For 
if (supportsSessionDataCaching() && level == getTransactionIsolationX())
			return;

I think we need to remove supportsSessionDataCaching()  because we don't want setTrasactionIsolation to behave differently and always commit if the server does not support session data caching.

It seems that _isolation is set to TRANSACTION_UNKNOWN for new connections.  This means we will always make an extra round trip for the first setTransactionIsolation call on a connection.  Can we initialize _isolation to READ_COMMITTED when  session data caching is supported instead since that is the default for new connections?



      was (Author: kmarsden):
    For 
if (supportsSessionDataCaching() && level == getTransactionIsolationX())
			return;

I think we need to remove supportsSessionDataCaching()  because we don't want setTrasactionIsolation to behave differently and always commit if the server does not support session data caching.

It seems that _isolation is set to TRANSACTION_UNKNOWN for new connections.  This means we will always make an extra round trip for the first setTransactionIsolation call on a connection.  Can we initialize _isolation to READ_COMMITTED instead since that is the default for new connections?


  
> With derby client setTransactionIsolation executes and commits even if isolation has not changed 
> -------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4314
>                 URL: https://issues.apache.org/jira/browse/DERBY-4314
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC, Network Client
>    Affects Versions: 10.1.3.1, 10.2.2.0, 10.3.3.0, 10.4.2.0, 10.5.1.1, 10.6.0.0
>            Reporter: Kathey Marsden
>            Priority: Minor
>         Attachments: DERBY-4314-2.diff, DERBY-4314.diff
>
>
> With in EmbedConnection.setIsolation() we have a check to see if the isolation level is the same and if so just return without doing a commit:
>   public void setTransactionIsolation(int level) throws SQLException {
> 		if (level == getTransactionIsolation())
> 			return;
> with org.apache.derby.client.am.Connection we have no such check. It would be good if the client driver acted like embedded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.