You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/16 07:28:09 UTC

Review Request 29088: Removed an unnecessary helper in the sorter tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29088/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos-git


Description
-------

This helper is no longer necessary, and the EXPECT statments inside a method loses line number information when the tests fail.


Diffs
-----

  src/tests/sorter_tests.cpp 0516ab573d9f4f2af249978e15ebf52c2afb5359 

Diff: https://reviews.apache.org/r/29088/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request 29088: Removed an unnecessary helper in the sorter tests.

Posted by Ben Mahler <be...@gmail.com>.


> On Dec. 16, 2014, 6:16 p.m., Jie Yu wrote:
> > src/tests/sorter_tests.cpp, line 71
> > <https://reviews.apache.org/r/29088/diff/1/?file=792868#file792868line71>
> >
> >     Curious if the following will compile or not:
> >     
> >     EXPECT_EQ(sorter.sort(), {"a", "b"});

Since the expected value should be on the left, I had tried the following unsuccessfully:

```
EXPECT_EQ({"a", "b"}, sorter.sort());
```

Also, likely don't want to risk another 4.4.7 issue with implicit construction from initializer lists, given the issue benh reported.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29088/#review65217
-----------------------------------------------------------


On Dec. 16, 2014, 6:28 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29088/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 6:28 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This helper is no longer necessary, and the EXPECT statments inside a method loses line number information when the tests fail.
> 
> 
> Diffs
> -----
> 
>   src/tests/sorter_tests.cpp 0516ab573d9f4f2af249978e15ebf52c2afb5359 
> 
> Diff: https://reviews.apache.org/r/29088/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 29088: Removed an unnecessary helper in the sorter tests.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29088/#review65217
-----------------------------------------------------------

Ship it!



src/tests/sorter_tests.cpp
<https://reviews.apache.org/r/29088/#comment108252>

    Curious if the following will compile or not:
    
    EXPECT_EQ(sorter.sort(), {"a", "b"});


- Jie Yu


On Dec. 16, 2014, 6:28 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29088/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 6:28 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This helper is no longer necessary, and the EXPECT statments inside a method loses line number information when the tests fail.
> 
> 
> Diffs
> -----
> 
>   src/tests/sorter_tests.cpp 0516ab573d9f4f2af249978e15ebf52c2afb5359 
> 
> Diff: https://reviews.apache.org/r/29088/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>