You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/07 04:10:03 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #4645: [Improvement][alert ] Multiple instances of alert service
codecov-io edited a comment on pull request #4645:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4645#issuecomment-770727647
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645?src=pr&el=h1) Report
> Merging [#4645](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645?src=pr&el=desc) (4fbbdc0) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/947dcb90cc9d4c032770050fd82218355f23dbd6?el=desc) (947dcb9) will **increase** coverage by `0.25%`.
> The diff coverage is `32.43%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4645 +/- ##
============================================
+ Coverage 44.91% 45.17% +0.25%
- Complexity 3369 3394 +25
============================================
Files 537 539 +2
Lines 23032 23131 +99
Branches 2684 2693 +9
============================================
+ Hits 10345 10449 +104
+ Misses 11760 11747 -13
- Partials 927 935 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/dolphinscheduler/alert/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Db25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...hinscheduler/service/alert/AlertClientService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvYWxlcnQvQWxlcnRDbGllbnRTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../dolphinscheduler/alert/utils/ZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9ab29rZWVwZXJDbGllbnQuamF2YQ==) | `72.00% <72.00%> (ø)` | `4.00 <4.00> (?)` | |
| [...lphinscheduler/alert/exception/AlertException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9leGNlcHRpb24vQWxlcnRFeGNlcHRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
| [...olphinscheduler/dao/datasource/BaseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQmFzZURhdGFTb3VyY2UuamF2YQ==) | `61.66% <0.00%> (-10.89%)` | `21.00% <0.00%> (ø%)` | |
| [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `66.66% <0.00%> (-5.56%)` | `8.00% <0.00%> (-1.00%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.70% <0.00%> (-2.82%)` | `11.00% <0.00%> (-2.00%)` | |
| [.../apache/dolphinscheduler/common/utils/OSUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09TVXRpbHMuamF2YQ==) | `44.18% <0.00%> (-0.26%)` | `24.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `4.56% <0.00%> (-0.05%)` | `2.00% <0.00%> (ø%)` | |
| ... and [23 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645?src=pr&el=footer). Last update [947dcb9...4fbbdc0](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4645?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org