You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2013/03/01 20:57:13 UTC

[jira] [Commented] (WICKET-5068) PageParameters missing from re-created Page

    [ https://issues.apache.org/jira/browse/WICKET-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590890#comment-13590890 ] 

Sven Meier commented on WICKET-5068:
------------------------------------

We could keep the original parameter in a special parameter, so PageProvider is able to recreate an expired page with the same parameters, see attached rudimentary patch.
                
> PageParameters missing from re-created Page
> -------------------------------------------
>
>                 Key: WICKET-5068
>                 URL: https://issues.apache.org/jira/browse/WICKET-5068
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.4.0
>         Environment: All
>            Reporter: bernard
>         Attachments: wicket-5068.patch
>
>
> WICKET-4594 removes existing PageParameters when re-creating an expired page.
> It does this under the assumption that the parameters are not needed for callback behavior that must not be executed after expiry.
> However PageParameters are needed even without execution of callback behavior.
> In trivial cases, a page cannot be re-constructed successfully without PageParameters e.g. a view page for a customer order needs the order ID from its PageParameters.
> There is a bit of an irony about this. To improve the recovery behavior, i.e. to avoid the dreaded PageExpiryException, one needs to create some client state which is then lost on re-creation after expiry.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira