You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@fineract.apache.org by "Vishwas Babu A J (JIRA)" <ji...@apache.org> on 2019/03/01 07:55:00 UTC

[jira] [Closed] (FINERACT-711) Pull Request template on Github

     [ https://issues.apache.org/jira/browse/FINERACT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vishwas Babu A J closed FINERACT-711.
-------------------------------------
    Resolution: Fixed

> Pull Request template on Github
> -------------------------------
>
>                 Key: FINERACT-711
>                 URL: https://issues.apache.org/jira/browse/FINERACT-711
>             Project: Apache Fineract
>          Issue Type: Task
>            Reporter: Vishwas Babu A J
>            Priority: Trivial
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> There seems to be inconsistency in updating API docs and Integration tests with new Pr's. Having a pull request template with a checklist listing out the following would help alleviate these concerns
>  
>  * Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed
>  * 
> API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes
>  * 
> Integration tests have been created/updated for verifying the changes made
>  * 
> All Integrations tests are passing with the new commit
>  * 
> Commit message starts with the issues number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)