You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by co...@jakarta.apache.org on 2004/09/24 13:58:32 UTC
[jira] Created: (JELLY-150) j:forEach tag not properly using varStatus attribute
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0-beta-5
swt-1.0
jface-1.0
jface-1.0-beta-1
1.1-beta-1
1.0
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Fri, 24 Sep 2004 4:57 AM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Hans Gilde
Created: Mon, 4 Oct 2004 5:27 PM
Body:
I'm opposed to doing this. It will mean that we have to bundle the whole JSTL JAR, just to use one interface.
Unless we're going to go full JSTL.... couldn't we just include our own, mock implementation of the interface in question? As long as it has the same methods, it will work just as well.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53698
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Mon, 4 Oct 2004 5:27 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Closed: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
Message:
The following issue has been closed.
Resolver: dion gillard
Date: Sun, 17 Oct 2004 11:00 PM
Committed fix. Now using jstl jar.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Closed
Priority: Major
Resolution: FIXED
Project: jelly
Components:
core / taglib.core
Fix Fors:
1.0
Versions:
1.0-beta-4
1.0-beta-5
swt-1.0
jface-1.0
jface-1.0-beta-1
1.1-beta-1
1.0
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Sun, 17 Oct 2004 11:00 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Wed, 6 Oct 2004 4:58 AM
Body:
Any comments on my patch?
It seems to resolve the concerns we have about adding jstl to the dependencies, and it works.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53751
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Wed, 6 Oct 2004 4:58 AM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following issue has been updated:
Updater: Ben Anderson (mailto:benanderson@benanderson.us)
Date: Fri, 24 Sep 2004 4:59 AM
Comment:
I did:
cvs diff -u > forEach.patch
and then just appended the new files at the end.
Changes:
Attachment changed to forEach.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://issues.apache.org/jira/browse/JELLY-150?page=history
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0-beta-5
swt-1.0
jface-1.0
jface-1.0-beta-1
1.1-beta-1
1.0
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Fri, 24 Sep 2004 4:59 AM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Ben Anderson
Created: Wed, 6 Oct 2004 5:56 AM
Body:
<snip>
If I replace the custom LoopStatus in ForEachTag with the JSTL one, and keep the rest, what is the difference between our patches?
</snip>
Are there any good tools for comparing or injecting diffs? I want to do a diff on my files vs. your files instead of your diff vs my diff. Sorry, like I said I'm new to Apache development, so diff(unified formart)/svn/etc. is all new to me. I think you understand that the LoopTagStatus in jstl.jar is only interface, right? We'll still need to implement it - probably in an inner class... whether it's anonymous or not I don't really care. I think being an inner class is fine, because it's not used by any other classes.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53755
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Wed, 6 Oct 2004 5:56 AM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following issue has been updated:
Updater: dion gillard (mailto:dion@apache.org)
Date: Mon, 4 Oct 2004 11:35 PM
Comment:
Here's a patch that doesn't require loop status, and passes the same tests.
Comments?
Changes:
Attachment changed to jelly-150-dg.txt
---------------------------------------------------------------------
For a full history of the issue, see:
http://issues.apache.org/jira/browse/JELLY-150?page=history
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Mon, 4 Oct 2004 11:35 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Mon, 4 Oct 2004 5:04 PM
Body:
If we need LoopTagStatus, we should add it to our dependencies, not include it in our source code.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53696
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Mon, 4 Oct 2004 5:04 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following issue has been updated:
Updater: Ben Anderson (mailto:benanderson@benanderson.us)
Date: Wed, 29 Sep 2004 4:05 PM
Comment:
This is the same patch as before, but it actually works. I wrote more extensive testing. The fix over this one as to the previos patch is that I was creating an anonymous inner class, which extended Object. Now I copied the LoopTagStatus interface from standard taglibs, so that the anonymous inner class implements that. That seems to have fixed the problem. Also, I found another existing bug. The "end" attribute in supposed to be inclusive, but it was behaving as exclusive.
Changes:
Attachment changed to forEach2.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://issues.apache.org/jira/browse/JELLY-150?page=history
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Wed, 29 Sep 2004 4:05 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Wed, 6 Oct 2004 5:39 AM
Body:
"Off course that's getting away from standards for no legitimate reason."
The reason, so far, has been licensing and details about jstl.jar.
If it's part of the standard taglibs from Apache, then fine. However, jars from Sun licensed under their Binary Code License have not been previously allowed to be distributed on ibiblio.
I'm happy if we can depend on jstl.jar as the sources are part of the standard taglib. See http://cvs.apache.org/viewcvs.cgi/jakarta-taglibs/standard/src/javax/servlet/jsp/jstl/core/LoopTagStatus.java?rev=1.4.2.1&only_with_tag=STANDARD_1_0_BRANCH&view=markup
So. If I replace the custom LoopStatus in ForEachTag with the JSTL one, and keep the rest, what is the difference between our patches?
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53753
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Wed, 6 Oct 2004 5:39 AM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Wed, 6 Oct 2004 5:46 AM
Body:
Differences from memory:
- You are creating a new LoopTagStatus class each time through the loop, I was reusing a single instance.
- You only handled one branch in the ForEachTag code.
- You removed the indexVar, whereas I left it alone.
- Your logic for isLast is easier, but relies on the itemsSize private variable, which should be declared inside doTag, and which doesn't handle iterators.
I'm also not sure we're going for a completely compatible JSTL implementation, as our EL is slightly different. As you say, we possibly should remove that chunk on the homepage.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53754
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Wed, 6 Oct 2004 5:46 AM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Wed, 6 Oct 2004 2:18 PM
Body:
Ok, so general consensus is to add JSTL.jar and use an anonymous implementation of it instead of the LoopStatus class.
Unless someone disagrees in the next few days, I'll commit a change to that effect.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53787
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Wed, 6 Oct 2004 2:18 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Paul Libbrecht <pa...@activemath.org>.
Le 4 oct. 04, à 15:36, Ben Anderson a écrit :
> you make a valid point. I had just copied that interface from the
> jakarta-taglibs project. It is an interface - not a class. I'll
> admit, I
> don't know too much about licensing. I was just assuming that it's
> legal to
> create a physical manifestion of interfaces defined by Sun.
It's perfectly legal. Licenses tend yo restrict people at transmission
times... download such an interface's class-file may be the time when
this get restricted. For example, the servlet 2.1 API license (at least
when downloaded from Sun) had a license claim that said that the
licensee can redistribute the jar along with your own product at latest
180 days after the latest release of the servlet 2.1 API!
JCP outcomes licensing has been a hot topic and I don't know wether
that's really set...
> The actual
> implementation is done in an anonymous inner class. How else would we
> stick to
> the standards defined by jstl? Isn't this the whole point of the JCP?
> The
> community defines the spec, which can be implemented by anyone. As a
> side
> note, the servletapi in the maven repository does not contain this
> interface.
> Essentially the only difference in not having this dependency vs.
> having it is
> the namespace. The dependency doesn't change, it's just whether the
> name is:
> javax.servlet.jsp.jstl.core.LoopTagStatus
> or
> org.apache.commons.jelly.whatever.LoopTagStatus
But the class-name is irrelevant for Jexl... do you need anything else
than jexl (or any other reflection-based system) ?
paul
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Ben Anderson <be...@benanderson.us>.
you make a valid point. I had just copied that interface from the
jakarta-taglibs project. It is an interface - not a class. I'll admit, I
don't know too much about licensing. I was just assuming that it's legal to
create a physical manifestion of interfaces defined by Sun. The actual
implementation is done in an anonymous inner class. How else would we stick to
the standards defined by jstl? Isn't this the whole point of the JCP? The
community defines the spec, which can be implemented by anyone. As a side
note, the servletapi in the maven repository does not contain this interface.
Essentially the only difference in not having this dependency vs. having it is
the namespace. The dependency doesn't change, it's just whether the name is:
javax.servlet.jsp.jstl.core.LoopTagStatus
or
org.apache.commons.jelly.whatever.LoopTagStatus
-Ben
Quoting Paul Libbrecht <pa...@activemath.org>:
> As Hans said,
>
> We don't want to introduce such a dependency in the core jelly.
> It used to be a problem because it wasn't maven distributable... now it
> looks like it actually is maven distributed (under the project-name
> servletapi).
> I'd like to have a kind of better confirmation than just seeing it in
> the maven repository before comitting to such a jump. (the licenses in
> the maven repo are... Apache license! I doubt this is from Sun).
>
> Do note that, if you want to use it from jexl, it is probably
> irrelevant wether it is actually of the given class or just implements
> all the methods with same signature. So, before the immensely long time
> someone of Sun actually claims the Apache license is correct, it might
> be faster to just write an class with the same methods...
>
> paul
>
>
> Le 4 oct. 04, à 13:08, Ben Anderson a écrit :
>
> > no, it belongs in javax.servlet.
> > http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/
> > jstl/core/LoopTagSupport.html
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Paul Libbrecht <pa...@activemath.org>.
As Hans said,
We don't want to introduce such a dependency in the core jelly.
It used to be a problem because it wasn't maven distributable... now it
looks like it actually is maven distributed (under the project-name
servletapi).
I'd like to have a kind of better confirmation than just seeing it in
the maven repository before comitting to such a jump. (the licenses in
the maven repo are... Apache license! I doubt this is from Sun).
Do note that, if you want to use it from jexl, it is probably
irrelevant wether it is actually of the given class or just implements
all the methods with same signature. So, before the immensely long time
someone of Sun actually claims the Apache license is correct, it might
be faster to just write an class with the same methods...
paul
Le 4 oct. 04, à 13:08, Ben Anderson a écrit :
> no, it belongs in javax.servlet.
> http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/
> jstl/core/LoopTagSupport.html
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Ben Anderson <be...@benanderson.us>.
Yes, I consulted that page. What do you mean "include the new files on the end
of cvs diff -u"? This is what I did:
$echo 'src/test/org/apache/commons/jelly/core/testForEachTag.jelly' >>site.patch
$cat src/test/org/apache/commons/jelly/core/testForEachTag.jelly >>site.patch
Was I on the right track? I tried what it sounds like you're saying:
$ cvs diff -u ./src/test/org/apache/commons/jelly/core/TestForEachTag.java
cvs server: I know nothing about
./src/test/org/apache/commons/jelly/core/TestForEachTag.java
If I contribute another patch in the future, I'd like it to be done correctly.
;-)
Thanks,
Ben
Quoting Hans Gilde <hg...@earthlink.net>:
> Ben,
>
> Now I see what you did with the patch. See
> http://jakarta.apache.org/commons/patches.html for the diff command. All you
> have to do is include the new files on the end of cvs diff -u and they'll be
> a part of the patch.
>
> Hans
>
> -----Original Message-----
> From: Ben Anderson [mailto:benanderson@benanderson.us]
> Sent: Monday, October 04, 2004 6:08 AM
> To: Jakarta Commons Developers List
> Subject: Re: (JELLY-150) j:forEach tag not properly using varStatus
> attribute
>
> no, it belongs in javax.servlet.
> http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/co
> re/LoopTagSupport.html
> Does your "unified format" comment pertain to the diff file I posted? This
> is
> the first patch I've ever submitted. I wasn't sure what to do with the new
> files, so I appended them to that file. I'm assuming this is not the way to
> do
> it, but I didn't know how. If someone will let me know how I'm supposed to
> do
> it, I'll do it when I get home tonight (I can't access Jira here at work)
> Thanks,
> Ben
>
> Quoting commons-dev@jakarta.apache.org:
>
> > The following comment has been added to this issue:
> >
> > Author: Hans Gilde
> > Created: Sat, 2 Oct 2004 9:30 PM
> > Body:
> > This patch adds a class in the package javax.servlet. This is a no-no.
> > Everything should be in a jelly packge. Maybe LoopTagStatus should be a
> > public static inner class of LoopTagStatus?
> >
> > Also, this patch isn't the Unified format.
> >
> > I haven't looked over the logic, yet, just the structure.
> >
> > ---------------------------------------------------------------------
> > View this comment:
> >
> http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53634
> >
> > ---------------------------------------------------------------------
> > View the issue:
> > http://issues.apache.org/jira/browse/JELLY-150
> >
> > Here is an overview of the issue:
> > ---------------------------------------------------------------------
> > Key: JELLY-150
> > Summary: j:forEach tag not properly using varStatus attribute
> > Type: Bug
> >
> > Status: Unassigned
> > Priority: Major
> >
> > Project: jelly
> > Components:
> > core / taglib.core
> > Versions:
> > 1.0-beta-4
> > 1.0
> > 1.1-beta-1
> > jface-1.0-beta-1
> > jface-1.0
> > swt-1.0
> > 1.0-beta-5
> >
> > Assignee:
> > Reporter: Ben Anderson
> >
> > Created: Fri, 24 Sep 2004 4:57 AM
> > Updated: Sat, 2 Oct 2004 9:30 PM
> > Environment: win2k / cygwin
> >
> > Description:
> > According to the jstl specification 1.1, the varStatus attribute of the
> > forEach tag should create a variable with type
> > javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set
> with
> > type Integer which contains the index of the current iteration. I created
> a
> > test case (I don't think any existed for forEach) that demonstrates this.
> I
> > also began making the fix, but it doesn't fully work. I am submitting my
> > patch along with the test cases. The comments I placed in the code should
> be
> > enough to tip someone off as to why it's not working (I hope). I am
> > relatively new to jelly (been using the standard taglibs for awhile) and
> have
> > never opened the source before. I am willing to complete the patch, but
> will
> > probably need some guidance because I messed with it for awhile before
> > determing I couldn't complete without some help. Thanks! :-)
> >
> >
> > ---------------------------------------------------------------------
> > JIRA INFORMATION:
> > This message is automatically generated by JIRA.
> >
> > If you think it was sent incorrectly contact one of the administrators:
> > http://issues.apache.org/jira/secure/Administrators.jspa
> >
> > If you want more information on JIRA, or have a bug to report see:
> > http://www.atlassian.com/software/jira
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Hans Gilde <hg...@earthlink.net>.
Ben,
Now I see what you did with the patch. See
http://jakarta.apache.org/commons/patches.html for the diff command. All you
have to do is include the new files on the end of cvs diff -u and they'll be
a part of the patch.
Hans
-----Original Message-----
From: Ben Anderson [mailto:benanderson@benanderson.us]
Sent: Monday, October 04, 2004 6:08 AM
To: Jakarta Commons Developers List
Subject: Re: (JELLY-150) j:forEach tag not properly using varStatus
attribute
no, it belongs in javax.servlet.
http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/co
re/LoopTagSupport.html
Does your "unified format" comment pertain to the diff file I posted? This
is
the first patch I've ever submitted. I wasn't sure what to do with the new
files, so I appended them to that file. I'm assuming this is not the way to
do
it, but I didn't know how. If someone will let me know how I'm supposed to
do
it, I'll do it when I get home tonight (I can't access Jira here at work)
Thanks,
Ben
Quoting commons-dev@jakarta.apache.org:
> The following comment has been added to this issue:
>
> Author: Hans Gilde
> Created: Sat, 2 Oct 2004 9:30 PM
> Body:
> This patch adds a class in the package javax.servlet. This is a no-no.
> Everything should be in a jelly packge. Maybe LoopTagStatus should be a
> public static inner class of LoopTagStatus?
>
> Also, this patch isn't the Unified format.
>
> I haven't looked over the logic, yet, just the structure.
>
> ---------------------------------------------------------------------
> View this comment:
>
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53634
>
> ---------------------------------------------------------------------
> View the issue:
> http://issues.apache.org/jira/browse/JELLY-150
>
> Here is an overview of the issue:
> ---------------------------------------------------------------------
> Key: JELLY-150
> Summary: j:forEach tag not properly using varStatus attribute
> Type: Bug
>
> Status: Unassigned
> Priority: Major
>
> Project: jelly
> Components:
> core / taglib.core
> Versions:
> 1.0-beta-4
> 1.0
> 1.1-beta-1
> jface-1.0-beta-1
> jface-1.0
> swt-1.0
> 1.0-beta-5
>
> Assignee:
> Reporter: Ben Anderson
>
> Created: Fri, 24 Sep 2004 4:57 AM
> Updated: Sat, 2 Oct 2004 9:30 PM
> Environment: win2k / cygwin
>
> Description:
> According to the jstl specification 1.1, the varStatus attribute of the
> forEach tag should create a variable with type
> javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set
with
> type Integer which contains the index of the current iteration. I created
a
> test case (I don't think any existed for forEach) that demonstrates this.
I
> also began making the fix, but it doesn't fully work. I am submitting my
> patch along with the test cases. The comments I placed in the code should
be
> enough to tip someone off as to why it's not working (I hope). I am
> relatively new to jelly (been using the standard taglibs for awhile) and
have
> never opened the source before. I am willing to complete the patch, but
will
> probably need some guidance because I messed with it for awhile before
> determing I couldn't complete without some help. Thanks! :-)
>
>
> ---------------------------------------------------------------------
> JIRA INFORMATION:
> This message is automatically generated by JIRA.
>
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
>
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Ben Anderson <be...@benanderson.us>.
no, it belongs in javax.servlet.
http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/core/LoopTagSupport.html
Does your "unified format" comment pertain to the diff file I posted? This is
the first patch I've ever submitted. I wasn't sure what to do with the new
files, so I appended them to that file. I'm assuming this is not the way to do
it, but I didn't know how. If someone will let me know how I'm supposed to do
it, I'll do it when I get home tonight (I can't access Jira here at work)
Thanks,
Ben
Quoting commons-dev@jakarta.apache.org:
> The following comment has been added to this issue:
>
> Author: Hans Gilde
> Created: Sat, 2 Oct 2004 9:30 PM
> Body:
> This patch adds a class in the package javax.servlet. This is a no-no.
> Everything should be in a jelly packge. Maybe LoopTagStatus should be a
> public static inner class of LoopTagStatus?
>
> Also, this patch isn't the Unified format.
>
> I haven't looked over the logic, yet, just the structure.
>
> ---------------------------------------------------------------------
> View this comment:
> http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53634
>
> ---------------------------------------------------------------------
> View the issue:
> http://issues.apache.org/jira/browse/JELLY-150
>
> Here is an overview of the issue:
> ---------------------------------------------------------------------
> Key: JELLY-150
> Summary: j:forEach tag not properly using varStatus attribute
> Type: Bug
>
> Status: Unassigned
> Priority: Major
>
> Project: jelly
> Components:
> core / taglib.core
> Versions:
> 1.0-beta-4
> 1.0
> 1.1-beta-1
> jface-1.0-beta-1
> jface-1.0
> swt-1.0
> 1.0-beta-5
>
> Assignee:
> Reporter: Ben Anderson
>
> Created: Fri, 24 Sep 2004 4:57 AM
> Updated: Sat, 2 Oct 2004 9:30 PM
> Environment: win2k / cygwin
>
> Description:
> According to the jstl specification 1.1, the varStatus attribute of the
> forEach tag should create a variable with type
> javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with
> type Integer which contains the index of the current iteration. I created a
> test case (I don't think any existed for forEach) that demonstrates this. I
> also began making the fix, but it doesn't fully work. I am submitting my
> patch along with the test cases. The comments I placed in the code should be
> enough to tip someone off as to why it's not working (I hope). I am
> relatively new to jelly (been using the standard taglibs for awhile) and have
> never opened the source before. I am willing to complete the patch, but will
> probably need some guidance because I messed with it for awhile before
> determing I couldn't complete without some help. Thanks! :-)
>
>
> ---------------------------------------------------------------------
> JIRA INFORMATION:
> This message is automatically generated by JIRA.
>
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
>
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Hans Gilde
Created: Sat, 2 Oct 2004 9:30 PM
Body:
This patch adds a class in the package javax.servlet. This is a no-no. Everything should be in a jelly packge. Maybe LoopTagStatus should be a public static inner class of LoopTagStatus?
Also, this patch isn't the Unified format.
I haven't looked over the logic, yet, just the structure.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53634
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Sat, 2 Oct 2004 9:30 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Mon, 4 Oct 2004 5:04 PM
Body:
What license is the JSTL jar under? Does the standard taglib ship with this interface?
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53697
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Mon, 4 Oct 2004 5:04 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Ben Anderson
Created: Wed, 6 Oct 2004 5:12 AM
Body:
Well, that certainly will work. Off course that's getting away from standards for no legitimate reason. Just to add the discussion - the jstl.jar IS on ibiblio's repository and it's a whopping 20k. Standard taglibs does ship with it. I don't see what the big deal is. IMHO, Jelly should either decide to include this dependency or else take all the jstl claims off the front page:
http://jakarta.apache.org/commons/jelly/
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53752
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Wed, 6 Oct 2004 5:12 AM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Ben Anderson
Created: Mon, 4 Oct 2004 12:40 PM
Body:
The interface is defined here:
http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/core/LoopTagSupport.html
There was some discussion following this on the mailing list. Personally, I don't see why it can't go in javax.servlet, but it should be fine to put it in some other package. Does your "unified format" comment pertain to the diff file I posted? This is the first patch I've ever submitted. I wasn't sure what to do with the new files, so I appended them to that file. I'm assuming this is not the way to do it, but I didn't know how. If someone will let me know how I'm supposed to do it, I'll resubmit the correctly formatted file.
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53683
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0
1.1-beta-1
jface-1.0-beta-1
jface-1.0
swt-1.0
1.0-beta-5
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Mon, 4 Oct 2004 12:40 PM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by co...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Ben Anderson
Created: Wed, 6 Oct 2004 6:54 AM
Body:
- You are creating a new LoopTagStatus class each time through the loop, I was reusing a single instance.
agreed - good catch!
- You only handled one branch in the ForEachTag code.
I'm unsure what you mean here.
- You removed the indexVar, whereas I left it alone.
agreed - better to leave it.
- Your logic for isLast is easier, but relies on the itemsSize private variable, which should be declared inside doTag, and which doesn't handle iterators.
agreed - I new I didn't do that the best way, but wasn't sure how to do it better. Yours looks good!
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53758
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JELLY-150
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JELLY-150
Summary: j:forEach tag not properly using varStatus attribute
Type: Bug
Status: Unassigned
Priority: Major
Project: jelly
Components:
core / taglib.core
Versions:
1.0-beta-4
1.0-beta-5
swt-1.0
jface-1.0
jface-1.0-beta-1
1.1-beta-1
1.0
Assignee:
Reporter: Ben Anderson
Created: Fri, 24 Sep 2004 4:57 AM
Updated: Wed, 6 Oct 2004 6:54 AM
Environment: win2k / cygwin
Description:
According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org