[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #12104: [PIP 97] Update Authentication Interfaces to Include Async Authentication Methods

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #12104:
URL: https://github.com/apache/pulsar/pull/12104#discussion_r1046794694


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProvider.java:
##########
@@ -61,7 +87,9 @@ public interface AuthenticationProvider extends Closeable {
      * @return the "role" string for the authenticated connection, if the authentication was successful
      * @throws AuthenticationException
      *             if the credentials are not valid
+     * @deprecated use and implement {@link AuthenticationProvider#authenticateAsync(AuthenticationDataSource)} instead.
      */
+    @Deprecated

Review Comment:
   Could you explain more about it? IMO, it should not be deprecated. I tried to implement an `AuthenticationProvider` that only overrides the `authenticationAsync` method but it never went here. Instead, the `authenticate` method was still called. There is no test to show it should be deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org