[Bug 377] Changed - Convert regexp test suite to JUnit BugRat Report#667

[bu...@apache.org]

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=377

*** shadow/377	Wed Feb 21 23:30:15 2001
--- shadow/377.tmp.7269	Wed Feb 21 23:31:43 2001
***************
*** 7,13 ****
  |     Severity: Enhancement              OS/Version: All                     |
  |     Priority: High                      Component: Other                   |
  +----------------------------------------------------------------------------+
! |  Assigned To: ant-dev@jakarta.apache.org                                   |
  |  Reported By: pholser@mindspring.com                                       |
  |      CC list: Cc:                                                          |
  +----------------------------------------------------------------------------+
--- 7,13 ----
  |     Severity: Enhancement              OS/Version: All                     |
  |     Priority: High                      Component: Other                   |
  +----------------------------------------------------------------------------+
! |  Assigned To: regexp-dev@jakarta.apache.org                                |
  |  Reported By: pholser@mindspring.com                                       |
  |      CC list: Cc:                                                          |
  +----------------------------------------------------------------------------+

Re: [Bug 377] Changed - Convert regexp test suite to JUnit BugRat Report#667

[Stefan Bodewig <bo...@bost.de>]

Michael McCallum <gh...@xtra.co.nz> wrote:

>} Take a look at the JUnit testcases for the regexp stuff in Ant
>} itself - we have a base testcase that gets applied to the different
>} regexp implementations Ant supports.

> I will extend that somehow to support what I want. Which should be
> reasonably trivial.  And submit a patch to ant-dev.

Fine. 

When I wrote these testcases they were simply there to ensure I didn't
break anything with my additional abstraction layer (which should be
replaced by a javax.regexp abstraction if this will ever become
reality IMO) and/or understood the philosophy of the processor in
question.

They are far away from testing regexp processors thoroughly -
especially since I'm nowhere near an expert. Having said that, I'd
like to get some feedback on Ant's regexp abstraction so that we could
improve it (I'd like to add pattern replacing which is directly
supported by some processors there for example).

If you extend them, please try to make them as modular as possible
(maybe even more so than what I did) - break them into several
different methods so that we can disable some testcases in subclasses
like I had to do for the GNU RE package. 

The preferred solution would be to fix the processor, I know ...

> If it does not get accepted there then I will just use it locally

I'm quite sure it would be accepted ;-)

Stefan

Re: [Bug 377] Changed - Convert regexp test suite to JUnit BugRat Report#667

[Michael McCallum <gh...@xtra.co.nz>]

} Take a look at the JUnit testcases for the regexp stuff in Ant itself
} - we have a base testcase that gets applied to the different regexp
} implementations Ant supports.
I will extend that somehow to support what I want. Which should be reasonably trivial.
And submit a patch to ant-dev.

If it does not get accepted there then I will just use it locally.

Re: [Bug 377] Changed - Convert regexp test suite to JUnit BugRat Report#667

[Stefan Bodewig <bo...@bost.de>]

Michael McCallum <mi...@spinsoftware.com> wrote:

> Did not look at the reply address :)

This is the nice thing about mailing lists setting reply-to headers 8-)

>> I'd suggest you take a look at Ant's <junit> task.

> Have. What I was thinking is that this is a junit test that I would
> like to include in both regexp and oro but dont wish to copy and
> paste the code to poth repositories.  

I see.

> I think that with ant using the regexp packages itself it needs to
> test to make sure they are working to standard.

Take a look at the JUnit testcases for the regexp stuff in Ant itself
- we have a base testcase that gets applied to the different regexp
implementations Ant supports.

> Given that you can use another regexp package by implementing the
> RegExpMatcher interface its possible that people will want to use
> third party package so there should be a test suite that the users
> can use to make sure the package is performing.

I've done so myself for the GNU variety of regexp engines. Together
with some customization to the base testcase as GNU RE doesn't agree
with my interpretation of regular expressions. See
<http://jakarta.apache.org/~bodewig/>.

Stefan

Welcome: Michael McCallum

[Jon Stevens <jo...@latchkey.com>]

Michael McCallum is the newest member of the jakarta-regexp family of people
with commit access.

thanks,

-jon

-- 
If you come from a Perl or PHP background, JSP is a way to take
your pain to new levels. --Anonymous
<http://jakarta.apache.org/velocity/> && <http://java.apache.org/turbine/>

Re: [Bug 377] Changed - Convert regexp test suite to JUnit BugRat Report#667

[Michael McCallum <mi...@spinsoftware.com>]

Did not look at the reply address :)

> I'd suggest you take a look at Ant's <junit> task.
Have. What I was thinking is that this is a junit test that I would like to include in both regexp 
and oro but dont wish to copy and paste the code to poth repositories.
I think that with ant using the regexp packages itself it needs to test to make sure they are 
working to standard. 

Given that you can use another regexp package by implementing the RegExpMatcher interface 
its possible that people will want to use third party package so there should be a test suite that 
the users can use to make sure the package is performing.
Perhaps it should be part of JUnit itself?

Michael

--- BEGIN GEEK CODE BLOCK ---
Version 3.12
GCS d+(-) s:- a-- C++(+++)$ UL++++(H)(S)$ P+++$ L+++$>++++
E--- W++ N++ o++ K? !w() O? !M V? PS+ PE+++ Y+ t+ 5++ X++ 
R(+) !tv b++(++++) D++ G>++ e++> h--()(*) r+ y+()
--- END GEEK CODE BLOCK ---

Re: [Bug 377] Changed - Convert regexp test suite to JUnit BugRat Report#667

[Stefan Bodewig <bo...@apache.org>]

Michael, I think you wanted to send this to regexp-dev instead of
ant-dev.

This bug has originally been raised against Ant and I have simply
reassigned it to the Regexp project (for which I've created a new
bugzilla entry).

Michael McCallum <gh...@xtra.co.nz> wrote:

> I am working on this at the moment.
> Would quite like to see you finding/alterations.
> 
> I did mention this in a post to this list last week.
> 
> My plan is to create a JUnit test suit run from probably an xml
> file.  I have already implemented one in the last couple of week but
> am unable to use that codebase so must write it again from scratch.

I'd suggest you take a look at Ant's <junit> task.

Stefan

Re: [Bug 377] Changed - Convert regexp test suite to JUnit BugRat Report#667

[Stefan Bodewig <bo...@apache.org>]

Michael, I think you wanted to send this to regexp-dev instead of
ant-dev.

This bug has originally been raised against Ant and I have simply
reassigned it to the Regexp project (for which I've created a new
bugzilla entry).

Michael McCallum <gh...@xtra.co.nz> wrote:

> I am working on this at the moment.
> Would quite like to see you finding/alterations.
> 
> I did mention this in a post to this list last week.
> 
> My plan is to create a JUnit test suit run from probably an xml
> file.  I have already implemented one in the last couple of week but
> am unable to use that codebase so must write it again from scratch.

I'd suggest you take a look at Ant's <junit> task.

Stefan

Re: [Bug 377] Changed - Convert regexp test suite to JUnit BugRat Report#667

[Michael McCallum <gh...@xtra.co.nz>]

I am working on this at the moment.
Would quite like to see you finding/alterations.

I did mention this in a post to this list last week.

My plan is to create a JUnit test suit run from probably an xml file.
I have already implemented one in the last couple of week but am 
unable to use that codebase so must write it again from scratch.

Michael