You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2018/06/19 01:21:39 UTC
Review Request 67639: Export count-down to forceful Maintenace as a
metric.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67639/
-----------------------------------------------------------
Review request for Aurora, Franck Cuny and Jordan Ly.
Repository: aurora
Description
-------
Since the scheduler enforces a maximum timeout on each
maintenance request and we now allow CoordinatorSlaPolicy
to block maintenance, we need to know which tasks are
running into the force maintenance timeout. Export maintenace
count down time as a metric brokwen down by task keys.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java 7fc5990dfb04c5528a44142c3efdd6d60d08188d
Diff: https://reviews.apache.org/r/67639/diff/1/
Testing
-------
./gradlew test
**Tested in Vagrant**
sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
######################################################################## 100.0%
maintenance_countdown_ms_vagrant/test/coordinator/0 264523
maintenance_countdown_ms_vagrant/test/coordinator/1 24476
sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
######################################################################## 100.0%
maintenance_countdown_ms_vagrant/test/coordinator/0 264523
maintenance_countdown_ms_vagrant/test/coordinator/1 24476
sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
######################################################################## 100.0%
maintenance_countdown_ms_vagrant/test/coordinator/0 264523
maintenance_countdown_ms_vagrant/test/coordinator/1 0
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 67639: Export count-down to forceful Maintenace as
a metric.
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67639/#review205005
-----------------------------------------------------------
Ship it!
Ship It!
- Jordan Ly
On June 19, 2018, 1:21 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67639/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 1:21 a.m.)
>
>
> Review request for Aurora, Franck Cuny and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Since the scheduler enforces a maximum timeout on each
> maintenance request and we now allow CoordinatorSlaPolicy
> to block maintenance, we need to know which tasks are
> running into the force maintenance timeout. Export maintenace
> count down time as a metric brokwen down by task keys.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java 7fc5990dfb04c5528a44142c3efdd6d60d08188d
>
>
> Diff: https://reviews.apache.org/r/67639/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
> **Tested in Vagrant**
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 0
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67639: Export count-down to forceful Maintenace as
a metric.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67639/#review204974
-----------------------------------------------------------
Master (9c9b592) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 19, 2018, 1:21 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67639/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 1:21 a.m.)
>
>
> Review request for Aurora, Franck Cuny and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Since the scheduler enforces a maximum timeout on each
> maintenance request and we now allow CoordinatorSlaPolicy
> to block maintenance, we need to know which tasks are
> running into the force maintenance timeout. Export maintenace
> count down time as a metric brokwen down by task keys.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java 7fc5990dfb04c5528a44142c3efdd6d60d08188d
>
>
> Diff: https://reviews.apache.org/r/67639/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
> **Tested in Vagrant**
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 0
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67639: Export count-down to forceful Maintenace as
a metric.
Posted by Franck Cuny via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67639/#review205002
-----------------------------------------------------------
Ship it!
Thanks, I think this will be useful for SO to track on a dashboard and enable them to act manually if needed.
- Franck Cuny
On June 19, 2018, 1:21 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67639/
> -----------------------------------------------------------
>
> (Updated June 19, 2018, 1:21 a.m.)
>
>
> Review request for Aurora, Franck Cuny and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Since the scheduler enforces a maximum timeout on each
> maintenance request and we now allow CoordinatorSlaPolicy
> to block maintenance, we need to know which tasks are
> running into the force maintenance timeout. Export maintenace
> count down time as a metric brokwen down by task keys.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d
> src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java 7fc5990dfb04c5528a44142c3efdd6d60d08188d
>
>
> Diff: https://reviews.apache.org/r/67639/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
> **Tested in Vagrant**
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 24476
> sshanmugham::tw-mbp-sshanmugham {~}$ curl http://192.168.33.7:8081/vars | grep maintenance_countdown
> ######################################################################## 100.0%
> maintenance_countdown_ms_vagrant/test/coordinator/0 264523
> maintenance_countdown_ms_vagrant/test/coordinator/1 0
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>