You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/02 04:34:33 UTC

[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil

vivekratnavel opened a new pull request #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil
URL: https://github.com/apache/hadoop-ozone/pull/404
 
 
   ## What changes were proposed in this pull request?
   
   Save and reuse Random object in GenesisUtil
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-2552
   
   ## How was this patch tested?
   
   Verified that the project compiles successfully.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil
URL: https://github.com/apache/hadoop-ozone/pull/404#discussion_r362423610
 
 

 ##########
 File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/genesis/GenesisUtil.java
 ##########
 @@ -68,6 +68,8 @@ private GenesisUtil() {
 
   private static final int DB_FILE_LEN = 7;
   private static final String TMP_DIR = "java.io.tmpdir";
+  private static final Random RANDOM = new Random();
+  private static final String SCM_CLIENT_DEFAULT_ADDRESS = "127.0.0.1:0";
 
 Review comment:
   Sure. Fixed it!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai merged pull request #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil
URL: https://github.com/apache/hadoop-ozone/pull/404
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil
URL: https://github.com/apache/hadoop-ozone/pull/404#issuecomment-570116581
 
 
   @adoroszlai @dineshchitlangia @nandakumar131 Please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil
URL: https://github.com/apache/hadoop-ozone/pull/404#issuecomment-570288020
 
 
   @adoroszlai Thanks for the review and merge!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #404: HDDS-2552. Sonar: Save and reuse Random object in GenesisUtil
URL: https://github.com/apache/hadoop-ozone/pull/404#discussion_r362417640
 
 

 ##########
 File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/genesis/GenesisUtil.java
 ##########
 @@ -68,6 +68,8 @@ private GenesisUtil() {
 
   private static final int DB_FILE_LEN = 7;
   private static final String TMP_DIR = "java.io.tmpdir";
+  private static final Random RANDOM = new Random();
+  private static final String SCM_CLIENT_DEFAULT_ADDRESS = "127.0.0.1:0";
 
 Review comment:
   Given that this is also used for non-client SCM and OM addresses, wouldn't something like `RANDOM_LOCAL_ADDRESS` be a better name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org