You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jason Dillon (JIRA)" <ji...@codehaus.org> on 2007/04/05 01:03:20 UTC
[jira] Created: (MNG-2930) Update JavaMojoDescriptorExtractor to
make it more re-use friendly
Update JavaMojoDescriptorExtractor to make it more re-use friendly
------------------------------------------------------------------
Key: MNG-2930
URL: http://jira.codehaus.org/browse/MNG-2930
Project: Maven 2
Issue Type: Improvement
Components: Plugin Creation Tools
Reporter: Jason Dillon
Priority: Minor
Update the {{JavaMojoDescriptorExtractor}} in the {{maven-plugin-tools-java}} module to make it more friendly for reusability.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2930) Update JavaMojoDescriptorExtractor to
make it more re-use friendly
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92113 ]
Brian Fox commented on MNG-2930:
--------------------------------
Patch applied to https://svn.apache.org/repos/asf/maven/shared/branches/maven-plugin-tools-java-MNG-2930.
The unit tests seem to cover this and everything builds and passes.
> Update JavaMojoDescriptorExtractor to make it more re-use friendly
> ------------------------------------------------------------------
>
> Key: MNG-2930
> URL: http://jira.codehaus.org/browse/MNG-2930
> Project: Maven 2
> Issue Type: Improvement
> Components: Plugin Creation Tools
> Reporter: Jason Dillon
> Priority: Minor
> Attachments: MNG-2930.diff
>
>
> Update the {{JavaMojoDescriptorExtractor}} in the {{maven-plugin-tools-java}} module to make it more friendly for reusability.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2930) Update JavaMojoDescriptorExtractor to
make it more re-use friendly
Posted by "Jason Dillon (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated MNG-2930:
------------------------------
Fix Version/s: 2.0.7
> Update JavaMojoDescriptorExtractor to make it more re-use friendly
> ------------------------------------------------------------------
>
> Key: MNG-2930
> URL: http://jira.codehaus.org/browse/MNG-2930
> Project: Maven 2
> Issue Type: Improvement
> Components: Plugin Creation Tools
> Reporter: Jason Dillon
> Priority: Minor
> Fix For: 2.0.7
>
> Attachments: MNG-2930.diff
>
>
> Update the {{JavaMojoDescriptorExtractor}} in the {{maven-plugin-tools-java}} module to make it more friendly for reusability.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2930) Update JavaMojoDescriptorExtractor to
make it more re-use friendly
Posted by "Jason Dillon (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated MNG-2930:
------------------------------
Complexity: Novice (was: Intermediate)
Patch attached: Yes
> Update JavaMojoDescriptorExtractor to make it more re-use friendly
> ------------------------------------------------------------------
>
> Key: MNG-2930
> URL: http://jira.codehaus.org/browse/MNG-2930
> Project: Maven 2
> Issue Type: Improvement
> Components: Plugin Creation Tools
> Reporter: Jason Dillon
> Priority: Minor
> Fix For: 2.0.7
>
> Attachments: MNG-2930.diff
>
>
> Update the {{JavaMojoDescriptorExtractor}} in the {{maven-plugin-tools-java}} module to make it more friendly for reusability.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-2930) Update JavaMojoDescriptorExtractor to
make it more re-use friendly
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox closed MNG-2930.
--------------------------
Resolution: Fixed
Fix Version/s: (was: 2.0.7)
Patch applied to tools 2.2-SNAPSHOT.
> Update JavaMojoDescriptorExtractor to make it more re-use friendly
> ------------------------------------------------------------------
>
> Key: MNG-2930
> URL: http://jira.codehaus.org/browse/MNG-2930
> Project: Maven 2
> Issue Type: Improvement
> Components: Plugin Creation Tools
> Reporter: Jason Dillon
> Assignee: Brian Fox
> Priority: Minor
> Attachments: MNG-2930.diff
>
>
> Update the {{JavaMojoDescriptorExtractor}} in the {{maven-plugin-tools-java}} module to make it more friendly for reusability.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2930) Update JavaMojoDescriptorExtractor to
make it more re-use friendly
Posted by "Jason Dillon (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated MNG-2930:
------------------------------
Attachment: MNG-2930.diff
Attached patch:
* Removes usage of JavaSource, prefer JavaClass, drops getJavaClass()
* Promotes a few constants related to @component handling to public
* Promotes a few methods from private to protected to allow sub-class access
* Drops PluginDescriptor from createMojoDescriptor(), attaching to return value instead
* Adds validate(MojoDescriptor) with param validation logic
* Adds discoverClasses() to find all of the JavaClass objects to process
With these changes, extractors which can generate QDox JavaClass instances for their sources can use JavaMojoDescriptorExctractor as a super-class and override discoverClasses() and/or invoke createMojoDescriptor() if some additional handling needs to be done.
This works very well for my GroovyMojoDescriptorExtractor, which translates \*.groovy into slim Java bits to allow QDox to parse out the class, field and javadoc tags... and then processing of the tags is always in sync with the Java impl.
> Update JavaMojoDescriptorExtractor to make it more re-use friendly
> ------------------------------------------------------------------
>
> Key: MNG-2930
> URL: http://jira.codehaus.org/browse/MNG-2930
> Project: Maven 2
> Issue Type: Improvement
> Components: Plugin Creation Tools
> Reporter: Jason Dillon
> Priority: Minor
> Attachments: MNG-2930.diff
>
>
> Update the {{JavaMojoDescriptorExtractor}} in the {{maven-plugin-tools-java}} module to make it more friendly for reusability.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2930) Update JavaMojoDescriptorExtractor to
make it more re-use friendly
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_97294 ]
Jason van Zyl commented on MNG-2930:
------------------------------------
Brian, you want to merge it in proper and close the issue.
> Update JavaMojoDescriptorExtractor to make it more re-use friendly
> ------------------------------------------------------------------
>
> Key: MNG-2930
> URL: http://jira.codehaus.org/browse/MNG-2930
> Project: Maven 2
> Issue Type: Improvement
> Components: Plugin Creation Tools
> Reporter: Jason Dillon
> Priority: Minor
> Fix For: 2.0.7
>
> Attachments: MNG-2930.diff
>
>
> Update the {{JavaMojoDescriptorExtractor}} in the {{maven-plugin-tools-java}} module to make it more friendly for reusability.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira