[jira] [Commented] (CASSANDRA-9774) fix sstableverify dtest

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622523#comment-14622523 ] 

Benedict commented on CASSANDRA-9774:
-------------------------------------

I'm afraid I'm not the best person to ask about that, as I'm not familiar with these tools. All I can tell you is that whenever you see "was not released before the reference was garbage collected" it is a bug, not a feature :)

> fix sstableverify dtest
> -----------------------
>
>                 Key: CASSANDRA-9774
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9774
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jim Witschey
>            Assignee: Jim Witschey
>            Priority: Blocker
>             Fix For: 3.0.x
>
>
> One of our dtests for {{sstableverify}} ({{offline_tools_test.py:TestOfflineTools.sstableverify_test}}) is failing hard on trunk ([cassci history|http://cassci.datastax.com/view/trunk/job/trunk_dtest/lastCompletedBuild/testReport/offline_tools_test/TestOfflineTools/sstableverify_test/history/])
> The way the test works is by deleting an SSTable, then running {{sstableverify}} on its table. In earlier versions, it successfully detects this problem and outputs that it "was not released before the reference was garbage collected". The test no longer finds this string in the output; looking through the output of the test, it doesn't look like it reports any problems at all.
> EDIT: After digging into the C* source a bit, I may have misattributed the problem to {{sstableverify}}; this could be a more general memory management problem, as the error text expected in the dtest is emitted by part of the {{Ref}} implementation:
> https://github.com/apache/cassandra/blob/075ff5000ced24b42f3b540815cae471bee4049d/src/java/org/apache/cassandra/utils/concurrent/Ref.java#L187



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)