You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/11 11:35:00 UTC
[jira] [Commented] (NIFI-5292) Rename existing ElasticSearch client
service impl to specify it is for 5.X
[ https://issues.apache.org/jira/browse/NIFI-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507930#comment-16507930 ]
ASF GitHub Bot commented on NIFI-5292:
--------------------------------------
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2782
NIFI-5292 Renamed ElasticSearch client service impl to show it is for…
… 5x.
NIFI-5292 Added 6.X ES Client.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MikeThomsen/nifi NIFI-5292
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2782.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2782
----
commit d5efbc3538da554eaef8c0b2e981bc4121a15ca8
Author: Mike Thomsen <mi...@...>
Date: 2018-06-11T10:53:14Z
NIFI-5292 Renamed ElasticSearch client service impl to show it is for 5x.
NIFI-5292 Added 6.X ES Client.
----
> Rename existing ElasticSearch client service impl to specify it is for 5.X
> --------------------------------------------------------------------------
>
> Key: NIFI-5292
> URL: https://issues.apache.org/jira/browse/NIFI-5292
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Mike Thomsen
> Assignee: Mike Thomsen
> Priority: Major
>
> The current version of the impl is 5.X, but has a generic name that will be confusing down the road.
> Add an ES 6.X client service as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)