[GitHub] [flink] azagrebin commented on a change in pull request #7921: [FLINK-11825][StateBackends] Resolve name class of StateTTL TimeCharacteristic class

[GitBox <gi...@apache.org>]

azagrebin commented on a change in pull request #7921: [FLINK-11825][StateBackends] Resolve name class of StateTTL TimeCharacteristic class
URL: https://github.com/apache/flink/pull/7921#discussion_r263432469
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
 ##########
 @@ -71,32 +73,61 @@
 	}
 
 	/**
+	 * @deprecated use {@link TtlTimeCharacteristic} to avoid class name clash
+	 * with <code>org.apache.flink.streaming.api.TimeCharacteristic</code>.
+	 *
 	 * This option configures time scale to use for ttl.
 	 */
+	@Deprecated
 	public enum TimeCharacteristic {
 		/** Processing time, see also <code>TimeCharacteristic.ProcessingTime</code>. */
 		ProcessingTime
 	}
 
+	/**
+	 * This option configures time scale to use for ttl.
+	 */
+	public enum TtlTimeCharacteristic {
+		/** Processing time, see also <code>org.apache.flink.streaming.api.TimeCharacteristic.ProcessingTime</code>. */
+		ProcessingTime
+	}
+
 	private final UpdateType updateType;
 	private final StateVisibility stateVisibility;
-	private final TimeCharacteristic timeCharacteristic;
+	@Deprecated
+	private TimeCharacteristic timeCharacteristic;
 
 Review comment:
   could we get rid of this field, also in Builder? `TimeCharacteristic` can be always converted into `TtlTimeCharacteristic` and back in relevant methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services