You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by reudismam <gi...@git.apache.org> on 2018/11/04 16:34:28 UTC

[GitHub] ant pull request #77: Avoid FileInputStream and FileOutputStream.

GitHub user reudismam opened a pull request:

    https://github.com/apache/ant/pull/77

    Avoid FileInputStream and FileOutputStream.

    Avoid FileInputStream and FileOutputStream. These classes override the finalize method. As a result, their objects are only cleaned when the garbage collector performs a sweep. Since Java 7, programmers can use Files.newInputStream and Files.newOutputStream instead of FileInputStream and FileOutputStream to improve performance as recommended in this Java JDK bug-report.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reudismam/ant newstream

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 0950db58654ff0f853dcfd7110f7d27500acbf5b
Author: = <re...@...>
Date:   2018-11-04T16:31:37Z

    Avoid FileInputStream and FileOutputStream.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] ant pull request #77: Avoid FileInputStream and FileOutputStream.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/ant/pull/77


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/77
  
    this is ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/77
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/77
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/Ant%20Github-PR-Linux/83/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/77
  
    Thanks @reudismam 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] ant issue #77: Avoid FileInputStream and FileOutputStream.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/ant/pull/77
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/Ant%20Github-PR-Windows/89/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org