(superset) branch tdd/issue-36775-filter-value-numeric-sort created (now 418abb4de0f)

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a change to branch tdd/issue-36775-filter-value-numeric-sort
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 418abb4de0f test(filters): pin numeric filter values sort numerically, not lexicographically (#36775)

This branch includes the following new commits:

     new 418abb4de0f test(filters): pin numeric filter values sort numerically, not lexicographically (#36775)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(superset) 01/01: test(filters): pin numeric filter values sort numerically, not lexicographically (#36775)

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch tdd/issue-36775-filter-value-numeric-sort
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 418abb4de0fcb5f88739ca1028bc4e86e9921a46
Author: Claude Code <no...@anthropic.com>
AuthorDate: Wed Jul 29 17:54:05 2026 -0700

    test(filters): pin numeric filter values sort numerically, not lexicographically (#36775)
    
    Closes #36775
    
    Adds a regression test on PluginFilterSelect confirming that when no
    sortMetric is configured, numeric filter-value options are ordered by
    their numeric value (2, 10, 100) rather than by lexicographic
    comparison of their formatted string labels (10, 100, 2).
    
    Root cause: SelectFilterPlugin's sortComparator always compares the
    formatted `label` via propertyComparator('label'). getDataRecordFormatter
    (superset-frontend/src/filters/utils.ts) always returns a string, so
    numeric columns hit propertyComparator's string branch (localeCompare)
    instead of its numeric branch, even though the values themselves are
    numeric. This is the second recurrence of the #35008/#34858 fix, which
    patched SelectControl.jsx (chart-builder numeric selects like Row limit)
    but never touched this native-filter value dropdown.
    
    Co-Authored-By: Claude Sonnet 5 <no...@anthropic.com>
---
 .../components/Select/SelectFilterPlugin.test.tsx  | 74 ++++++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
index 1db796a0dce..c96eb1bff54 100644
--- a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
+++ b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
@@ -720,6 +720,80 @@ describe('SelectFilterPlugin', () => {
     expect(options[2]).toHaveTextContent('beta');
   });
 
+  test('sorts numeric filter values numerically, not lexicographically, when no sortMetric is specified', () => {
+    // Regression for #36775: numeric filter values were sorted as strings
+    // (localeCompare on the formatted label), producing "1, 10, 100, 2"
+    // instead of the expected "1, 2, 10, 100".
+    const testData = [{ age: 10 }, { age: 2 }, { age: 100 }];
+
+    const testProps = {
+      ...selectMultipleProps,
+      formData: {
+        ...selectMultipleProps.formData,
+        groupby: ['age'],
+        sortMetric: undefined,
+        sortAscending: true,
+      },
+      queriesData: [
+        {
+          rowcount: 3,
+          colnames: ['age'],
+          coltypes: [0],
+          data: testData,
+          applied_filters: [{ column: 'age' }],
+          rejected_filters: [],
+        },
+      ],
+      filterState: {
+        value: [],
+        label: '',
+        excludeFilterValues: true,
+      },
+    };
+
+    render(
+      // @ts-expect-error
+      <SelectFilterPlugin
+        // @ts-expect-error
+        {...transformProps(testProps)}
+        setDataMask={jest.fn()}
+        showOverflow={false}
+      />,
+      {
+        useRedux: true,
+        initialState: {
+          nativeFilters: {
+            filters: {
+              'test-filter': {
+                name: 'Test Filter',
+              },
+            },
+          },
+          dataMask: {
+            'test-filter': {
+              extraFormData: {},
+              filterState: {
+                value: [],
+                label: '',
+                excludeFilterValues: true,
+              },
+            },
+          },
+        },
+      },
+    );
+
+    const filterSelect = screen.getAllByRole('combobox')[0];
+    userEvent.click(filterSelect);
+
+    // Options should appear in ascending numeric order (2, 10, 100), not
+    // ascending lexicographic order of their formatted labels (10, 100, 2).
+    const options = screen.getAllByRole('option');
+    expect(options[0]).toHaveTextContent('2');
+    expect(options[1]).toHaveTextContent('10');
+    expect(options[2]).toHaveTextContent('100');
+  });
+
   test('shows create option for multi-select creatable filter when typing', async () => {
     getWrapper({ creatable: true, multiSelect: true });
     userEvent.type(screen.getByRole('combobox'), 'brand-new');