You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/21 15:41:00 UTC

[GitHub] [cloudstack] ravening opened a new pull request #5799: HAproxy based load balancer customization

ravening opened a new pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799


   Add new feature for load balancers based on haproxy
   
   code ported from https://github.com/apache/cloudstack/pull/4141
   
   ### Description
   As discussed in mailing list, create this PR for haproxy config customization.
   
   FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/VR+haproxy+customization+in+CloudStack
   
   Fixes #3789
   
   It supports (or will support)
   
   Basic haproxy configurations:
   haproxy statistics uri, auth, enable/disable
   global maxconn and maxpipes
   Basic configurations on rule
   timeout connection, client ,server globally and per rule
   http, httpalive per rule
   maxconn, fullconn per rule
   maxconn, minconn, maxqueue per server in rule
   advanced features
   transparent load balancer
   SSL offloading
   http2 support
   Variable SSL configurations
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [X] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   Adding networks level haproxy configs
   
   ![Screenshot 2021-12-21 at 16 38 52](https://user-images.githubusercontent.com/10645273/146957291-99d56fea-993b-4bea-a19c-4a2c6563c7b9.png)
   
   
   Adding load balancer level configs
   ![Screenshot 2021-12-21 at 16 39 36](https://user-images.githubusercontent.com/10645273/146957394-db7cd49f-ab6f-43ba-abb9-2e0c9fefff2b.png)
   
   ![Screenshot 2021-12-21 at 16 39 56](https://user-images.githubusercontent.com/10645273/146957460-7ee1552e-a357-4624-821e-395b501f6844.png)
   ![Screenshot 2021-12-21 at 16 40 12](https://user-images.githubusercontent.com/10645273/146957502-78b8fdf7-e6a2-4741-8387-c5a00873b693.png)
   
   
   
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1034067241


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1034029726


   Thanks @ravening 
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1007876787


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1034485540


   <b>Trillian test result (tid-3273)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35254 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5799-t3273-kvm-centos7.zip
   Smoke tests completed. 86 look OK, 6 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.52 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
   test_01_lb_usage | `Error` | 0.00 | test_usage.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 32.87 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 63.49 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 33.86 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 29.80 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 119.62 | test_kubernetes_clusters.py
   test_01_secure_vm_migration | `Error` | 150.13 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 300.21 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 140.81 | test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 43.71 | test_vm_life_cycle.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 9.43 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 9.43 | test_snapshots.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.80 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1034062401


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2544


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1033767965


   > Hi @ravening is this PR ready for review? Can you please fix the conflicts?
   
   @nvazquez done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1007876787


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1034065164


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1059657035


   Sorry @ravening there are some conflicts again, can you please fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1034030719


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1007890657


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1030739584


   Hi @ravening is this PR ready for review? Can you please fix the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1007876829






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5799: HAproxy based load balancer customization

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5799:
URL: https://github.com/apache/cloudstack/pull/5799#issuecomment-1007876829


   @rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org