You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gr...@apache.org on 2023/12/20 20:45:43 UTC
(logging-chainsaw) 11/13: fixed throwing exception, made use of logger
This is an automated email from the ASF dual-hosted git repository.
grobmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-chainsaw.git
commit 2c7ac659f7201b82a37976acb356c3ce3a40a0fa
Author: Christian Grobmeier <cg...@grobmeier.de>
AuthorDate: Wed Dec 20 21:44:18 2023 +0100
fixed throwing exception, made use of logger
---
src/main/java/org/apache/log4j/scheduler/Scheduler.java | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/log4j/scheduler/Scheduler.java b/src/main/java/org/apache/log4j/scheduler/Scheduler.java
index 9a021f4..43aa1af 100644
--- a/src/main/java/org/apache/log4j/scheduler/Scheduler.java
+++ b/src/main/java/org/apache/log4j/scheduler/Scheduler.java
@@ -17,6 +17,10 @@
package org.apache.log4j.scheduler;
+import org.apache.log4j.chainsaw.logui.LogUI;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
import java.util.List;
import java.util.Vector;
@@ -31,7 +35,7 @@ import java.util.Vector;
* @author Ceki
*/
public class Scheduler extends Thread {
-
+ private static Logger logger = LogManager.getLogger(Scheduler.class);
/**
* Job list.
*/
@@ -92,7 +96,7 @@ public class Scheduler extends Thread {
if (i != -1) {
ScheduledJobEntry se = jobList.remove(i);
if (se.job != job) { // this should never happen
- new IllegalStateException("Internal programming error");
+ throw new IllegalStateException("Internal programming error");
}
// if the job is the first on the list,
// then notify the scheduler thread to schedule a new job
@@ -237,8 +241,7 @@ public class Scheduler extends Thread {
try {
job.execute();
} catch (Exception e) {
- System.err.println("The execution of the job threw an exception");
- e.printStackTrace(System.err);
+ logger.error("The execution of the job threw an exception", e);
}
}