You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2021/09/24 21:49:04 UTC

[GitHub] [incubator-heron] surahman opened a new pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

surahman opened a new pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717


   **_Issue #3707:_**
   
   Documentation for Pod Templates in `ConfigMap`s. The issue tracking this feature is #3710.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 merged pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
joshfischer1108 merged pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] surahman commented on pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
surahman commented on pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717#issuecomment-926938136


   Hi @joshfischer1108, I have created a very quick document outlining usage. There was an issue I found in the way I have handled looking up the Pod Templates but I will write that up in #3710.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] surahman commented on pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
surahman commented on pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717#issuecomment-938047280


   Updated, please feel free to add detail and make adjustments through GH review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] surahman commented on pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
surahman commented on pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717#issuecomment-934016410


   **_TODO:_** as per @nicknezis  suggestion, list the parts of the PodTemplate that will be replaced and the config items that can be used to set them (i.e. Env variables, labels, annotations).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] surahman commented on pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
surahman commented on pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717#issuecomment-955582829


   Thank you @joshfischer1108, I  really appreciate your time and effort!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 merged pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
joshfischer1108 merged pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis commented on pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717#issuecomment-926962947


   This is great. I'll be adding a similar document for the last Kubernetes scheduler feature I added. 
   
   Not asking you to do this refactor, but mentioning it to share the idea... I would like to combine the Kubernetes related documentation into a single page under the Schedulers menu. Then we can have sub-menu items for the various aspects of this scheduler. Something similar to this [Spark document](https://spark.apache.org/docs/latest/running-on-kubernetes.html).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] surahman commented on pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
surahman commented on pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717#issuecomment-927137689


   I have updated the instructions for the `CONFIGMAP-NAME.POD-TEMPLATE-NAME` change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] surahman commented on pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
surahman commented on pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717#issuecomment-938047280


   Updated, please feel free to add detail and make adjustments through GH review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] joshfischer1108 merged pull request #3717: [Heron 3707] ConfigMap Pod Template Support Documentation

Posted by GitBox <gi...@apache.org>.
joshfischer1108 merged pull request #3717:
URL: https://github.com/apache/incubator-heron/pull/3717


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org