You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/13 12:34:31 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new issue, #39: consider using parboiled2 as a jar dependency in v1.0.0
pjfanning opened a new issue, #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39
Relates to https://github.com/apache/incubator-pekko-http/issues/35
* by having a jar dependency, our licensing requirements are simplified
* by keeping a pekko copy of the source files, we need to account in more detail for this in out LICENSE and NOTICE
* one particularly problematic file is https://github.com/apache/incubator-pekko-http/blob/2e8b2fade52cf0a85d0150a407226851cf00c683/akka-parsing/src/main/java/akka/parboiled2/util/Base64.java
* has multiple authors at various stages and BSD and Apache licensing
* even maybe possible to use Java's Base64 class at this stage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39#issuecomment-1427888795
Btw. IIRC the original reasoning for vendoring was to avoid a transitive dependency on shapeless (which has now been removed from parboiled2) to avoid having to delay releases until shapeless is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39#issuecomment-1427889307
@jrudolph Do you have any comments on the Base64 situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning closed issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #39: consider using parboiled2 as a jar dependency in v1.0.0
URL: https://github.com/apache/incubator-pekko-http/issues/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39#issuecomment-1427869163
@jrudolph this is just for discussion but I'd be interested in your views on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39#issuecomment-1427895441
Also created https://github.com/apache/incubator-pekko-http/issues/40 to discuss Base64 situation specifically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39#issuecomment-1427891347
> In https://github.com/apache/incubator-pekko-http/pull/14, @mdedetrich suggested to move that change to the 1.1.x release but if it is easy enough to do I would also concur with doing this earlier if it simplifies the license situation.
I am fine with doing the release in 1.0.x if it simplifies the license situation dramatically. pekko-http due to being a http web server/client doesn't have as strict requirements as something like pekko-core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39#issuecomment-1427892768
I'll close this in favour of https://github.com/apache/incubator-pekko-http/issues/39 and link this discussion there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39#issuecomment-1427878059
> one particularly problematic file is https://github.com/apache/incubator-pekko-http/blob/2e8b2fade52cf0a85d0150a407226851cf00c683/akka-parsing/src/main/java/akka/parboiled2/util/Base64.java
> * has multiple authors at various stages and BSD and Apache licensing
> * even maybe possible to use Java's Base64 class at this stage
I will comment on the other stuff later, but I wouldn't advocate for removing/changing this for Java's Base64 class. There is a reason why this Base64 implementation is there, Base64 is used frequently in the context of http and as you can ready from the comments its a far more efficient implementation then Java's Base64. Generally speaking its also not unusual for the Akka/Pekko ecosystem to reimplement JVM API's if they are not very efficient (which isn't uncommon).
As an alternative we can make this base64 into its own sbt module/artifact which would make it fairly easy to add in custom licenses in a similar to what was done with pekko-core's protobuf modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #39: consider using parboiled2 as a jar dependency in v1.0.0
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #39:
URL: https://github.com/apache/incubator-pekko-http/issues/39#issuecomment-1427887724
This is a duplicate of #1. Basically, I agree with this move. In #14, @mdedetrich suggested to move that change to the 1.1.x release but if it is easy enough to do I would also concur with doing this earlier if it simplifies the license situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org