You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/01/02 02:00:14 UTC

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

onichols-pivotal commented on a change in pull request #5469:
URL: https://github.com/apache/geode/pull/5469#discussion_r550831212



##########
File path: geode-core/build.gradle
##########
@@ -366,6 +366,7 @@ dependencies {
 
     integrationTestRuntimeOnly('org.apache.derby:derby')
     integrationTestRuntimeOnly('xerces:xercesImpl')
+    integrationTestRuntimeOnly('com.fasterxml.jackson.datatype:jackson-datatype-jsr310')

Review comment:
       this seems like the wrong scope.  don't we need jackson-datatype-jdr310 jar to be included in the shipping product, not just available to this one test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org