You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "zymap (via GitHub)" <gi...@apache.org> on 2023/08/10 01:56:44 UTC

[GitHub] [bookkeeper] zymap commented on a diff in pull request #4041: Make compatible between DefaultEntryLogger and DirectEntryLogger

zymap commented on code in PR #4041:
URL: https://github.com/apache/bookkeeper/pull/4041#discussion_r1289441766


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:
##########
@@ -557,6 +568,17 @@ private long getLastLogId(File dir) {
         return logs.get(logs.size() - 1);
     }
 
+    private long getLastLogIdInDir(File dir) {

Review Comment:
   Don't we need to consider the gap? Like how it implemented in the EntryLogIdsImpl



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org