[GitHub] [spark] srowen commented on a change in pull request #20793: [SPARK-23643][CORE][SQL][ML] Shrinking the buffer in hashSeed up to size of the seed parameter

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #20793: [SPARK-23643][CORE][SQL][ML] Shrinking the buffer in hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793#discussion_r266502382
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala
 ##########
 @@ -739,7 +739,7 @@ class PairRDDFunctionsSuite extends SparkFunSuite with SharedSparkContext {
         val dist = new BinomialDistribution(trials, p)
         val q = dist.cumulativeProbability(actual)
         withClue(s"p = $p: trials = $trials") {
-          assert(q >= 0.001 && q <= 0.999)
+          assert(q >= 0.001 && q < 0.99999)
 
 Review comment:
   It's OK to increase the bounds, I was just saying they should be symmetric. Asserting it's in [0,1] is barely asserting anything except that the value isn't completely wrong. I'm OK with that too, but, don't think we should ever see 0 or 1. (0,1) could be a little more reasonable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org