You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/24 16:59:20 UTC
[GitHub] [dolphinscheduler] guoshupei opened a new issue, #10608: [Bug] [Worker] TaskInstance state update error
guoshupei opened a new issue, #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
find version: 2.0.1
When TaskExecuteThread is running, if an exception is threw, it is caught and the kill method is executed, but if kill methond also throw error instead of an exception, the `TaskExecuteResponseCommand` can not be set properties, like status, endTime, these can be set default value, for example, the `status` can be set 0 (state of `submit success`)
- log
- code
### What you expected to happen
The state of TaskInstance is correct
### How to reproduce
- 1. throw `exception/error `in try block
- 2. throw `error `in kill methond
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1259019054
@guoshupei Can 2.0.6 version be reproduced ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1166201462
@guoshupei Ok, so it's better to move the setting part to finally. Could you please submit a PR to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1165761581
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina closed issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
JinyLeeChina closed issue #10608: [Bug] [Worker] TaskInstance state update error
URL: https://github.com/apache/dolphinscheduler/issues/10608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1166214959
> >
>
> > @guoshupei Ok, so it's better to move the setting part to finally. Could you please submit a PR to fix this?
>
> yes , as you said, I need to know the task execution to set different states, failure or success. but I have another plan:
>
> * First, put `kill()` after setting part,
> * Second, replace `Exception` with `Throwable` of `catch` block in `kill` method
>
> WDYT?
The first plan looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1166181466
@ruanwenjun And if you look at my screenshot, although it's exception, it's actually reversed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1166218328
> > >
> >
> >
> > > @guoshupei Ok, so it's better to move the setting part to finally. Could you please submit a PR to fix this?
> >
> >
> > yes , as you said, I need to know the task execution to set different states, failure or success. but I have another plan:
> >
> > * First, put `kill()` after setting part,
> > * Second, replace `Exception` with `Throwable` of `catch` block in `kill` method
> >
> > WDYT?
>
> The first plan looks good to me.
okay，I will use first plan to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1380244701
The reason is the same as #13244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1166177607
I see the code in 2.0.5, the `kill` method will never throw exception. So this should already be fixed, I will close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun closed issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed issue #10608: [Bug] [Worker] TaskInstance state update error
URL: https://github.com/apache/dolphinscheduler/issues/10608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1166181054
@ruanwenjun not exception, but error. the user can custom task plugins, so override can be throw error , this happened with our custom Linkis plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1166214463
>
> @guoshupei Ok, so it's better to move the setting part to finally. Could you please submit a PR to fix this?
yes , as you said, I need to know the task execution to set different states, failure or success.
but I have another plan:
- First, put `kill()` after setting part,
- Second, replace `Exception` with `Throwable` of `catch` block in `kill` method
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1259106150
> @guoshupei Can 2.0.6 version be reproduced ？
I don't use the 2.0.6 version, but I think it still exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #10608: [Bug] [Worker] TaskInstance state update error
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #10608:
URL: https://github.com/apache/dolphinscheduler/issues/10608#issuecomment-1259121008
> @guoshupei Can 2.0.6 version be reproduced ？
@JinyLeeChina Here's how we do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org