You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/04/27 23:08:03 UTC

[jira] [Created] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

make forceUserDefinedCompaction actually do what it says
--------------------------------------------------------

                 Key: CASSANDRA-2575
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.7.1
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
            Priority: Minor
             Fix For: 0.7.6




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2575:
--------------------------------------

    Attachment: 2575.txt

corrected patch attached.

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2575:
--------------------------------------

    Attachment: 2575-v2.txt

bq. Also wondering if it couldn't make sense to not compact if we end up with only 1 sstable in doCompaction, now that you still can do a userDefinedCompaction on only 1 sstable

Good idea. v2 attached with a rewrite of the retry loop to do this.

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: 2575-v2.txt, 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2575:
--------------------------------------

    Description: See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026243#comment-13026243 ] 

Sylvain Lebresne commented on CASSANDRA-2575:
---------------------------------------------

I suppose we could backport to 0.7 too.
Also wondering if it couldn't make sense to not compact if we end up with only 1 sstable in doCompaction, now that you still can do a userDefinedCompaction on only 1 sstable. Not being able to compact the 2 smallest sstables seems pathological enough and it would be nice to avoid the 'same sstable compacted forever' problem seen in the mail thread above.

Anyway, +1 on the patch. 

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026077#comment-13026077 ] 

Stu Hood commented on CASSANDRA-2575:
-------------------------------------

The patch for 2552 is attached.

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6
>
>         Attachments: 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2575:
--------------------------------------

    Attachment: 2575.txt

patch splits out doCompactionWithoutSizeEstimates and calls that from submitUserDefined.

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6
>
>         Attachments: 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2575:
--------------------------------------

    Fix Version/s:     (was: 0.7.6)
                   0.8.0

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026356#comment-13026356 ] 

Sylvain Lebresne commented on CASSANDRA-2575:
---------------------------------------------

+1 on v2

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: 2575-v2.txt, 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027805#comment-13027805 ] 

Hudson commented on CASSANDRA-2575:
-----------------------------------

Integrated in Cassandra-0.8 #58 (See [https://builds.apache.org/hudson/job/Cassandra-0.8/58/])
    

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: 2575-v2.txt, 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2575) make forceUserDefinedCompaction actually do what it says

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2575:
--------------------------------------

    Attachment:     (was: 2575.txt)

> make forceUserDefinedCompaction actually do what it says
> --------------------------------------------------------
>
>                 Key: CASSANDRA-2575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: 2575.txt
>
>
> See http://www.mail-archive.com/user@cassandra.apache.org/msg12621.html for motivation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira