You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by codecov-io <gi...@git.apache.org> on 2017/12/08 22:19:45 UTC
[GitHub] jmeter issue #353: Re-wrote some existing tests in Spock

Github user codecov-io commented on the issue:

    https://github.com/apache/jmeter/pull/353
  
    # [Codecov](https://codecov.io/gh/apache/jmeter/pull/353?src=pr&el=h1) Report
    > Merging [#353](https://codecov.io/gh/apache/jmeter/pull/353?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/520fb63cca1aae665e45dae640ac91ec7adfc04b?src=pr&el=desc) will **decrease** coverage by `0.1%`.
    > The diff coverage is `92.54%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/353/graphs/tree.svg?src=pr&token=6Q7CI1wFSh&width=650&height=150)](https://codecov.io/gh/apache/jmeter/pull/353?src=pr&el=tree)
    
    ```diff
    @@             Coverage Diff              @@
    ##              trunk     #353      +/-   ##
    ============================================
    - Coverage     58.29%   58.19%   -0.11%     
    + Complexity    10242    10217      -25     
    ============================================
      Files          1160     1160              
      Lines         74375    74205     -170     
      Branches       7334     7326       -8     
    ============================================
    - Hits          43357    43182     -175     
    - Misses        28519    28522       +3     
    - Partials       2499     2501       +2
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/353?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
    |---|---|---|---|
    | [...g/apache/jmeter/control/RandomOrderController.java](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvY29udHJvbC9SYW5kb21PcmRlckNvbnRyb2xsZXIuamF2YQ==) | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
    | [test/src/org/apache/jmeter/JMeterVersionTest.java](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvSk1ldGVyVmVyc2lvblRlc3QuamF2YQ==) | `76.13% <0%> (-0.44%)` | `38 <0> (ø)` | |
    | [...he/jmeter/control/RandomOrderControllerSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvY29udHJvbC9SYW5kb21PcmRlckNvbnRyb2xsZXJTcGVjLmdyb292eQ==) | `100% <100%> (ø)` | `6 <6> (?)` | |
    | [...rg/apache/jmeter/engine/DistributedRunnerTest.java](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZW5naW5lL0Rpc3RyaWJ1dGVkUnVubmVyVGVzdC5qYXZh) | `87.77% <100%> (ø)` | `7 <0> (ø)` | :arrow_down: |
    | [...rg/apache/jmeter/control/ThroughputController.java](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvY29udHJvbC9UaHJvdWdocHV0Q29udHJvbGxlci5qYXZh) | `66.66% <100%> (+1.66%)` | `29 <5> (+1)` | :arrow_up: |
    | [...c/org/apache/jmeter/engine/util/PackageSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZW5naW5lL3V0aWwvUGFja2FnZVNwZWMuZ3Jvb3Z5) | `100% <100%> (ø)` | `5 <5> (?)` | |
    | [.../org/apache/jmeter/assertions/MD5HexAssertion.java](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9NRDVIZXhBc3NlcnRpb24uamF2YQ==) | `75% <50%> (-18.75%)` | `8 <0> (-1)` | |
    | [...pache/jmeter/assertions/MD5HexAssertionSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9NRDVIZXhBc3NlcnRpb25TcGVjLmdyb292eQ==) | `76.47% <76.47%> (ø)` | `5 <5> (?)` | |
    | [...che/jmeter/control/ThroughputControllerSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvY29udHJvbC9UaHJvdWdocHV0Q29udHJvbGxlclNwZWMuZ3Jvb3Z5) | `97.05% <97.05%> (ø)` | `8 <8> (?)` | |
    | [...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `27.77% <0%> (-3.18%)` | `10% <0%> (-1%)` | |
    | ... and [6 more](https://codecov.io/gh/apache/jmeter/pull/353/diff?src=pr&el=tree-more) | |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/353?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/353?src=pr&el=footer). Last update [520fb63...e9ab768](https://codecov.io/gh/apache/jmeter/pull/353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---