You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/17 06:59:52 UTC

[GitHub] [incubator-druid] gianm commented on issue #6743: IncrementalIndex generally overestimates theta sketch size

gianm commented on issue #6743: IncrementalIndex generally overestimates theta sketch size
URL: https://github.com/apache/incubator-druid/issues/6743#issuecomment-512129692
 
 
   @himanshug, I think most of that idea is good, except I'd prefer a special return value from `aggregate` rather than throwing an exception, for two reasons: exceptions are expensive to generate, and also that this situation is not really 'exceptional' (certain aggregators might be expected to exceed min size somewhat often).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org